Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-10 Thread Emil Velikov
On 10 May 2017 at 00:10, Dave Airlie wrote: > On 6 May 2017 at 02:35, Daniel Stone wrote: >> Hi Emil, >> >> On 4 May 2017 at 15:14, Emil Velikov wrote: >>> On 4 May 2017 at 14:43, Daniel Stone wrote: IOW, there is no change as far as I can see, but perhaps for the meantime, we could u

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-09 Thread Dave Airlie
On 6 May 2017 at 02:35, Daniel Stone wrote: > Hi Emil, > > On 4 May 2017 at 15:14, Emil Velikov wrote: >> On 4 May 2017 at 14:43, Daniel Stone wrote: >>> IOW, there is no change as far as I can see, but perhaps for the >>> meantime, we could use an unreachable() at the bottom of >>> modifier_to_

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-05 Thread Daniel Stone
Hi Emil, On 4 May 2017 at 15:14, Emil Velikov wrote: > On 4 May 2017 at 14:43, Daniel Stone wrote: >> IOW, there is no change as far as I can see, but perhaps for the >> meantime, we could use an unreachable() at the bottom of >> modifier_to_tiling(). Would that help? >> > Yes the default statem

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-04 Thread Emil Velikov
On 4 May 2017 at 14:43, Daniel Stone wrote: > Hi Emil, > > On 4 May 2017 at 13:27, Emil Velikov wrote: >>> @@ -581,21 +600,17 @@ intel_create_image_common(__DRIscreen *dri_screen, >>> assert(!(use && count)); >>> >>> uint64_t modifier = select_best_modifier(&screen->devinfo, modifiers, >

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-04 Thread Daniel Stone
Hi Emil, On 4 May 2017 at 13:27, Emil Velikov wrote: >> @@ -581,21 +600,17 @@ intel_create_image_common(__DRIscreen *dri_screen, >> assert(!(use && count)); >> >> uint64_t modifier = select_best_modifier(&screen->devinfo, modifiers, >> count); >> - switch (modifier) { >> - case I915_

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-04 Thread Emil Velikov
On 4 May 2017 at 10:14, Daniel Stone wrote: > Use a helper function and struct to convert between a modifier and > tiling mode, so we can use it later for a tiling -> modifier lookup. > I think that this patch leads to a functionality change. See below for more. If that's intentional please mentio

[Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

2017-05-04 Thread Daniel Stone
Use a helper function and struct to convert between a modifier and tiling mode, so we can use it later for a tiling -> modifier lookup. Signed-off-by: Daniel Stone Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 49 +--- 1 file changed, 32 insertions(