Re: [Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-12 Thread Jason Ekstrand
On Sat, Dec 12, 2015 at 2:04 PM, Kenneth Graunke wrote: > On Saturday, December 12, 2015 02:01:49 PM Jason Ekstrand wrote: >> On Sat, Dec 12, 2015 at 2:00 PM, Jason Ekstrand wrote: >> > On Sat, Dec 12, 2015 at 12:22 PM, Kenneth Graunke >> > wrote: >> >> On Saturday, December 12, 2015 08:29:37 A

Re: [Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-12 Thread Kenneth Graunke
On Saturday, December 12, 2015 02:01:49 PM Jason Ekstrand wrote: > On Sat, Dec 12, 2015 at 2:00 PM, Jason Ekstrand wrote: > > On Sat, Dec 12, 2015 at 12:22 PM, Kenneth Graunke > > wrote: > >> On Saturday, December 12, 2015 08:29:37 AM Jason Ekstrand wrote: > >>> On Dec 11, 2015 1:24 PM, "Kenneth

Re: [Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-12 Thread Jason Ekstrand
On Sat, Dec 12, 2015 at 2:00 PM, Jason Ekstrand wrote: > On Sat, Dec 12, 2015 at 12:22 PM, Kenneth Graunke > wrote: >> On Saturday, December 12, 2015 08:29:37 AM Jason Ekstrand wrote: >>> On Dec 11, 2015 1:24 PM, "Kenneth Graunke" wrote: >> [snip] >>> > @@ -302,12 +302,12 @@ LOAD(shared, 1, 1,

Re: [Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-12 Thread Jason Ekstrand
On Sat, Dec 12, 2015 at 12:22 PM, Kenneth Graunke wrote: > On Saturday, December 12, 2015 08:29:37 AM Jason Ekstrand wrote: >> On Dec 11, 2015 1:24 PM, "Kenneth Graunke" wrote: > [snip] >> > @@ -302,12 +302,12 @@ LOAD(shared, 1, 1, NIR_INTRINSIC_CAN_ELIMINATE) >> > #define STORE(name, srcs, indi

Re: [Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-12 Thread Kenneth Graunke
On Saturday, December 12, 2015 08:29:37 AM Jason Ekstrand wrote: > On Dec 11, 2015 1:24 PM, "Kenneth Graunke" wrote: [snip] > > @@ -302,12 +302,12 @@ LOAD(shared, 1, 1, NIR_INTRINSIC_CAN_ELIMINATE) > > #define STORE(name, srcs, indices, flags) \ > > INTRINSIC(store_##name, srcs, ARR(0, 1, 1,

Re: [Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-12 Thread Jason Ekstrand
On Dec 11, 2015 1:24 PM, "Kenneth Graunke" wrote: > > Tessellation control shaders need to be careful when writing outputs. > Because multiple threads can concurrently write the same output > variables, we need to only write the exact components we were told. > > Traditionally, for sub-vector writ

[Mesa-dev] [PATCH v2 03/13] nir: Add a writemask to store intrinsics.

2015-12-11 Thread Kenneth Graunke
Tessellation control shaders need to be careful when writing outputs. Because multiple threads can concurrently write the same output variables, we need to only write the exact components we were told. Traditionally, for sub-vector writes, we've read the whole vector, updated the temporary, and wr