On Sat, Dec 12, 2015 at 2:04 PM, Kenneth Graunke <kenn...@whitecape.org> wrote:
> On Saturday, December 12, 2015 02:01:49 PM Jason Ekstrand wrote:
>> On Sat, Dec 12, 2015 at 2:00 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote:
>> > On Sat, Dec 12, 2015 at 12:22 PM, Kenneth Graunke <kenn...@whitecape.org>
>> > wrote:
>> >> On Saturday, December 12, 2015 08:29:37 AM Jason Ekstrand wrote:
>> >>> On Dec 11, 2015 1:24 PM, "Kenneth Graunke" <kenn...@whitecape.org> wrote:
>> >>> > /* src[] = { value, offset }. const_index[] = { base, write_mask } */
>> >>> > STORE(shared, 2, 1, 0)
>> >>
>> >> While we're here, this comment seems wrong, doesn't it? There's only
>> >> one index, but the comment lists two. (It's wrong before my patch...)
>> >
>> > Yes, we should fix that. It's only one index. That was my mistake
>> > while rebasing on shared variables.
>>
>> Scratch taht. This is correct. When doing shared variables, I
>> decided to go with base+offset since they are also opaque. That was
>> intentional.
>
> Then the code is wrong, not the comment... :(
Oh... So it is... That's not good. Let's get that fixed. Probably
best to be in its own patch. Feel free to fix it and slap my R-B on
it.
--Jason
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
