Re: [Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

2016-01-24 Thread Jordan Justen
On 2016-01-23 11:06:48, Kenneth Graunke wrote: > On Thursday, January 21, 2016 11:35:31 PM PST Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > > > I tested a release build. I think v1 produced comparable code to > > before the patch, but it was a bit larger. I found that this

Re: [Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

2016-01-23 Thread Kenneth Graunke
On Thursday, January 21, 2016 11:35:31 PM PST Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > > I tested a release build. I think v1 produced comparable code to > before the patch, but it was a bit larger. I found that this v2 code > would produce identical code to our current code

Re: [Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

2016-01-22 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2016-01-21 at 23:35 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > > I tested a release build. I think v1 produced comparable code to > before the patch, but it was a bit larger. I found that this v2 code > would produce identical c

Re: [Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

2016-01-22 Thread Timothy Arceri
On Thu, 2016-01-21 at 23:35 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > > I tested a release build. I think v1 produced comparable code to > before the patch, but it was a bit larger. I found that this v2 code > would produce identical code to our current code for releas

[Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

2016-01-21 Thread Jordan Justen
Signed-off-by: Jordan Justen --- I tested a release build. I think v1 produced comparable code to before the patch, but it was a bit larger. I found that this v2 code would produce identical code to our current code for release builds. Timothy, should I add your r-b for v2? src/glsl/glsl_p