Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-05 Thread Nanley Chery
On Wed, Oct 05, 2016 at 04:30:51PM -0700, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 02:47:22PM -0700, Nanley Chery wrote: > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > On Mon 26 Sep 2016, Nanley Chery wrote: > > > > From: Nanley Chery > > > > > > > > Provides an FPS

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-05 Thread Nanley Chery
On Tue, Sep 27, 2016 at 02:47:22PM -0700, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > On Mon 26 Sep 2016, Nanley Chery wrote: > > > From: Nanley Chery > > > > > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > > > demos. > >

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-04 Thread Nanley Chery
On Tue, Oct 04, 2016 at 03:55:13PM -0700, Chad Versace wrote: > On Tue 04 Oct 2016, Nanley Chery wrote: > > On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote: > > > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand > > > wrote: > > > > > > > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Cher

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-04 Thread Chad Versace
On Tue 04 Oct 2016, Nanley Chery wrote: > On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote: > > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > > > > > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > > > wrote: > > > > > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Ver

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-04 Thread Nanley Chery
On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote: > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > > > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > > wrote: > > > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > >> > On Tue 27 Sep 2016, Nanley Chery wr

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-03 Thread Jason Ekstrand
On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > wrote: > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: >> > On Tue 27 Sep 2016, Nanley Chery wrote: >> > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: >> >

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-03 Thread Jason Ekstrand
On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > > On Tue 27 Sep 2016, Nanley Chery wrote: > > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > > > > As a consequence of that reasoning, we should set > 3DST

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-09-27 Thread Nanley Chery
On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > On Tue 27 Sep 2016, Nanley Chery wrote: > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > > As a consequence of that reasoning, we should set > > > 3DSTATE_CLEAR_PARAMS.DepthClearValueValid = 1 > > > whenever h

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-09-27 Thread Chad Versace
On Tue 27 Sep 2016, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > As a consequence of that reasoning, we should set > > 3DSTATE_CLEAR_PARAMS.DepthClearValueValid = 1 > > whenever hiz is enabled, even if we don't care about the actual clear value. > > In

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-09-27 Thread Nanley Chery
On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > On Mon 26 Sep 2016, Nanley Chery wrote: > > From: Nanley Chery > > > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > > demos. > > > > Clears that happen within a render pass via vkCmdClearAttachments ar

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-09-27 Thread Chad Versace
On Mon 26 Sep 2016, Nanley Chery wrote: > From: Nanley Chery > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > demos. > > Clears that happen within a render pass via vkCmdClearAttachments are safe > even if the clear color changes. This is because the meta implement

[Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-09-26 Thread Nanley Chery
From: Nanley Chery Provides an FPS increase of ~30% on the Sascha triangle and multisampling demos. Clears that happen within a render pass via vkCmdClearAttachments are safe even if the clear color changes. This is because the meta implementation does not use LOAD_OP_CLEAR which avoids any conf