Re: [Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

2015-11-03 Thread Matt Turner
On Tue, Nov 3, 2015 at 10:14 PM, Kenneth Graunke wrote: > On Wednesday, October 21, 2015 03:58:15 PM Matt Turner wrote: >> Initially just checks that sources are non-NULL, which would have >> alerted us to the problem fixed by commit 6c846dc5. >> --- >> src/mesa/drivers/dri/i965/Makefile.sources

Re: [Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

2015-11-03 Thread Kenneth Graunke
On Wednesday, October 21, 2015 03:58:15 PM Matt Turner wrote: > Initially just checks that sources are non-NULL, which would have > alerted us to the problem fixed by commit 6c846dc5. > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_eu.h

Re: [Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

2015-10-22 Thread Matt Turner
On Thu, Oct 22, 2015 at 4:15 AM, Emil Velikov wrote: > On 21 October 2015 at 23:58, Matt Turner wrote: >> Initially just checks that sources are non-NULL, which would have >> alerted us to the problem fixed by commit 6c846dc5. > > What are the chances of combining this with and/or removing > fs_v

Re: [Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

2015-10-22 Thread Emil Velikov
On 21 October 2015 at 23:58, Matt Turner wrote: > Initially just checks that sources are non-NULL, which would have > alerted us to the problem fixed by commit 6c846dc5. What are the chances of combining this with and/or removing fs_visitor::validate() ? Afaict both of these validations are at di

[Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

2015-10-21 Thread Matt Turner
Initially just checks that sources are non-NULL, which would have alerted us to the problem fixed by commit 6c846dc5. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_eu.h | 4 + src/mesa/drivers/dri/i965/brw_eu_validate.c | 150 +