Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-14 Thread Richard Sandiford
Will Schmidt writes: > On Thu, 2013-06-13 at 14:50 +0100, Richard Sandiford wrote: >> > > The entirety of the comment looks pretty good to me. :-) One > question, and this is mostly curiosity on my part, I'm not specifically > asking for another revision. > >> * (This is the same as C bi

Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-13 Thread Will Schmidt
On Thu, 2013-06-13 at 14:50 +0100, Richard Sandiford wrote: > The entirety of the comment looks pretty good to me. :-) One question, and this is mostly curiosity on my part, I'm not specifically asking for another revision. > * (This is the same as C bitfield layout on most ABIs.) Do w

Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-13 Thread Richard Sandiford
Michel Dänzer writes: > On Die, 2013-06-11 at 16:26 +0100, Richard Sandiford wrote: >> Signed-off-by: Richard Sandiford >> --- >> src/gallium/auxiliary/util/u_format.h | 42 >> ++- >> 1 file changed, 41 insertions(+), 1 deletion(-) >> >> diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-12 Thread Michel Dänzer
On Die, 2013-06-11 at 16:26 +0100, Richard Sandiford wrote: > Signed-off-by: Richard Sandiford > --- > src/gallium/auxiliary/util/u_format.h | 42 > ++- > 1 file changed, 41 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_format.h > b/

[Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-12 Thread Richard Sandiford
Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/util/u_format.h | 42 ++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_format.h b/src/gallium/auxiliary/util/u_format.h index e4b9c36..db6c290 100644 --- a/src