Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-24 Thread Anuj Phogat
On Sat, Oct 19, 2013 at 3:05 PM, Paul Berry wrote: > On 14 October 2013 10:12, Anuj Phogat wrote: >> >> Implement the FS backend for new builtins added by the extension: >> in vec2 gl_SamplePosition >> in int gl_SampleID >> in int gl_NumSamples >> out int gl_SampleMask[] > > > There is a lot goin

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-19 Thread Paul Berry
On 14 October 2013 10:12, Anuj Phogat wrote: > Implement the FS backend for new builtins added by the extension: > in vec2 gl_SamplePosition > in int gl_SampleID > in int gl_NumSamples > out int gl_SampleMask[] > There is a lot going on in this one patch, and it's getting hard to follow all the

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-19 Thread Paul Berry
On 18 October 2013 10:30, Anuj Phogat wrote: > I know we can specify stride if we have a brw_reg :- > fs_reg (stride(brw_vec1_grf(0, 0), 2, 4, 0)); > > But I could not find a reliable way to use stride if we have a fs_reg. > That's why I used OR to get the desired result. > The right way to do

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-18 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 5:42 PM, Anuj Phogat wrote: > On Tue, Oct 15, 2013 at 1:49 PM, Kenneth Graunke > wrote: >> On 10/14/2013 10:12 AM, Anuj Phogat wrote: >>> Implement the FS backend for new builtins added by the extension: >>> in vec2 gl_SamplePosition >>> in int gl_SampleID >>> in int gl_N

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 05:42 PM, Anuj Phogat wrote: [snip] >>> + /* WM will be run in MSDISPMODE_PERSAMPLE. So, only SIMD8 mode will be >> >> Looking at the docs for 3DSTATE_PS, I believe that SIMD16 is allowed in >> some cases... >> >> SNB: Must be SIMD8 only. >> IVB: >> - 4x MSAA: Either SIMD8 or SIMD1

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 3:28 PM, Kenneth Graunke wrote: > On 10/14/2013 10:12 AM, Anuj Phogat wrote: >> Implement the FS backend for new builtins added by the extension: >> in vec2 gl_SamplePosition >> in int gl_SampleID >> in int gl_NumSamples >> out int gl_SampleMask[] >> >> Signed-off-by: Anuj

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 1:49 PM, Kenneth Graunke wrote: > On 10/14/2013 10:12 AM, Anuj Phogat wrote: >> Implement the FS backend for new builtins added by the extension: >> in vec2 gl_SamplePosition >> in int gl_SampleID >> in int gl_NumSamples >> out int gl_SampleMask[] >> >> Signed-off-by: Anuj

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: > Implement the FS backend for new builtins added by the extension: > in vec2 gl_SamplePosition > in int gl_SampleID > in int gl_NumSamples > out int gl_SampleMask[] > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 1

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: > Implement the FS backend for new builtins added by the extension: > in vec2 gl_SamplePosition > in int gl_SampleID > in int gl_NumSamples > out int gl_SampleMask[] > > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 1

[Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-14 Thread Anuj Phogat
Implement the FS backend for new builtins added by the extension: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_fs.cpp | 109 +++ src/mesa/drivers/dri/i965/brw