On 16 January 2017 at 23:24, Mauro Rossi wrote:
>>> --- a/src/gallium/Android.mk
>>> +++ b/src/gallium/Android.mk
>>> @@ -34,7 +34,9 @@ SUBDIRS += auxiliary/pipe-loader
>>> #
>>>
>>> # swrast
>>> -ifneq ($(filter swrast,$(MESA_GPU_DRIVERS)),)
>>> +ifneq ($(filter llvmpipe,$(MESA_GPU_DRIVERS)),)
On 16 January 2017 at 19:50, Ilia Mirkin wrote:
> What's the problem with using GALLIUM_DRIVER=softpipe /
> GALLIUM_DRIVER=llvmpipe to select between them?
>
Will work, but has the "update existing users" drawback.
Afaict neither scons nor autotools uses such approach, so I'd rather
keep things sy
>> --- a/src/gallium/Android.mk
>> +++ b/src/gallium/Android.mk
>> @@ -34,7 +34,9 @@ SUBDIRS += auxiliary/pipe-loader
>> #
>>
>> # swrast
>> -ifneq ($(filter swrast,$(MESA_GPU_DRIVERS)),)
>> +ifneq ($(filter llvmpipe,$(MESA_GPU_DRIVERS)),)
>> +SUBDIRS += winsys/sw/dri drivers/llvmpipe drivers/sof
What's the problem with using GALLIUM_DRIVER=softpipe /
GALLIUM_DRIVER=llvmpipe to select between them?
On Mon, Jan 16, 2017 at 2:24 PM, Zhen Wu wrote:
> Thank you for your review. Emil. It sounds like renaming swrast to softpipe
> is not a good idea, Inspired by your second question, perhaps a n
Thank you for your review. Emil. It sounds like renaming swrast to softpipe
is not a good idea, Inspired by your second question, perhaps a new
MESA_ENABLE_LLVMPIPE would allow us to maintain backward compatibility and
keep the ability to switch between softpipe/llvmpipe. How does this sound?
201
Good catch
2017-01-10 17:15 GMT+08:00 Mauro Rossi :
> 2017-01-06 18:35 GMT+01:00 Wu Zhen :
> > From: WuZhen
> >
> > rename old swrast to softpipe, add a new driver llvmpipe
> >
> > Change-Id: Ia8bc1005ad6846df78bc1f6d0a4196310a049aca
> > Reviewed-by: Mauro Rossi
> > Reviewed-by: Chih-Wei Huang
On 6 January 2017 at 17:35, Wu Zhen wrote:
> From: WuZhen
>
> rename old swrast to softpipe, add a new driver llvmpipe
>
Generic comment:
Please keep mechanical changes (rename) separate from new
functionality (llvmpipe support).
Two [somewhat] open questions:
- If we rename swrast I would sugge
2017-01-06 18:35 GMT+01:00 Wu Zhen :
> From: WuZhen
>
> rename old swrast to softpipe, add a new driver llvmpipe
>
> Change-Id: Ia8bc1005ad6846df78bc1f6d0a4196310a049aca
> Reviewed-by: Mauro Rossi
> Reviewed-by: Chih-Wei Huang
> ---
> Android.common.mk| 2 +-
> Andr
From: WuZhen
rename old swrast to softpipe, add a new driver llvmpipe
Change-Id: Ia8bc1005ad6846df78bc1f6d0a4196310a049aca
Reviewed-by: Mauro Rossi
Reviewed-by: Chih-Wei Huang
---
Android.common.mk| 2 +-
Android.mk | 6 ++---
sr