Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-23 Thread Anuj Phogat
On Fri, Oct 18, 2013 at 2:57 PM, Paul Berry wrote: > On 14 October 2013 10:12, Anuj Phogat wrote: >> >> New builtins added by GL_ARB_sample_shading: >> in vec2 gl_SamplePosition >> in int gl_SampleID >> in int gl_NumSamples >> out int gl_SampleMask[] >> >> Signed-off-by: Anuj Phogat >> --- >> s

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-22 Thread Ian Romanick
On 10/22/2013 07:48 AM, Ian Romanick wrote: > On 10/16/2013 10:40 AM, Ian Romanick wrote: >> On 10/15/2013 07:50 PM, Kenneth Graunke wrote: >>> On 10/15/2013 01:58 PM, Ian Romanick wrote: On 10/15/2013 01:50 PM, Anuj Phogat wrote: > On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick > wr

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-22 Thread Ian Romanick
On 10/16/2013 10:40 AM, Ian Romanick wrote: > On 10/15/2013 07:50 PM, Kenneth Graunke wrote: >> On 10/15/2013 01:58 PM, Ian Romanick wrote: >>> On 10/15/2013 01:50 PM, Anuj Phogat wrote: On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: > On 10/14/2013 10:12 AM, Anuj Phogat wrot

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-18 Thread Paul Berry
On 14 October 2013 10:12, Anuj Phogat wrote: > New builtins added by GL_ARB_sample_shading: > in vec2 gl_SamplePosition > in int gl_SampleID > in int gl_NumSamples > out int gl_SampleMask[] > > Signed-off-by: Anuj Phogat > --- > src/glsl/builtin_variables.cpp | 11 +++ > src/glsl/link_v

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-17 Thread Anuj Phogat
On Wed, Oct 16, 2013 at 11:25 PM, Kenneth Graunke wrote: > On 10/16/2013 03:49 PM, Ian Romanick wrote: > [snip] >> You are completely correct here. We should check what other vendors do. >> I think 5 tests will tell us everything we need to know (then we'll >> probably submit some spec bugs). I

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Kenneth Graunke
On 10/16/2013 03:49 PM, Ian Romanick wrote: [snip] > You are completely correct here. We should check what other vendors do. > I think 5 tests will tell us everything we need to know (then we'll > probably submit some spec bugs). I don't have any non-Intel hardware > that supports either extensi

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Anuj Phogat
On Wed, Oct 16, 2013 at 3:49 PM, Ian Romanick wrote: > On 10/16/2013 11:29 AM, Kenneth Graunke wrote: >> On 10/16/2013 10:40 AM, Ian Romanick wrote: >>> On 10/15/2013 07:50 PM, Kenneth Graunke wrote: >> [snip] Right, but gl_SampleMask is not an unsized array. It's statically sized based

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Ian Romanick
On 10/16/2013 11:29 AM, Kenneth Graunke wrote: > On 10/16/2013 10:40 AM, Ian Romanick wrote: >> On 10/15/2013 07:50 PM, Kenneth Graunke wrote: > [snip] >>> Right, but gl_SampleMask is not an unsized array. It's statically sized >>> based on your implementation's maximum supported number of color s

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Matt Turner
On Wed, Oct 16, 2013 at 10:40 AM, Ian Romanick wrote: > On 10/15/2013 07:50 PM, Kenneth Graunke wrote: >> On 10/15/2013 01:58 PM, Ian Romanick wrote: >>> On 10/15/2013 01:50 PM, Anuj Phogat wrote: On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: > On 10/14/2013 10:12 AM, Anuj

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Kenneth Graunke
On 10/16/2013 11:29 AM, Kenneth Graunke wrote: > * Smaller than ceil(float(gl_NumSamples)/32.0): I misspoke here. gl_NumSamples is a uniform, and is the number of samples in the framebuffer. It isn't the implementation's maximum number of color samples, which is what actually goes in that formul

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Kenneth Graunke
On 10/16/2013 10:40 AM, Ian Romanick wrote: > On 10/15/2013 07:50 PM, Kenneth Graunke wrote: [snip] >> Right, but gl_SampleMask is not an unsized array. It's statically sized >> based on your implementation's maximum supported number of color samples >> (ceil(samples/32)), and this is totally know

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-16 Thread Ian Romanick
On 10/15/2013 07:50 PM, Kenneth Graunke wrote: > On 10/15/2013 01:58 PM, Ian Romanick wrote: >> On 10/15/2013 01:50 PM, Anuj Phogat wrote: >>> On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: > @@ -789,6 +794,12 @@ > builtin_variable_ge

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 01:58 PM, Ian Romanick wrote: > On 10/15/2013 01:50 PM, Anuj Phogat wrote: >> On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: >>> On 10/14/2013 10:12 AM, Anuj Phogat wrote: @@ -789,6 +794,12 @@ builtin_variable_generator::generate_fs_special_vars() if (state->A

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 10:02 AM, Ian Romanick wrote: > On 10/14/2013 10:12 AM, Anuj Phogat wrote: >> New builtins added by GL_ARB_sample_shading: >> in vec2 gl_SamplePosition >> in int gl_SampleID >> in int gl_NumSamples >> out int gl_SampleMask[] >> >> Signed-off-by: Anuj Phogat >> --- >> src/glsl/builti

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Ian Romanick
On 10/15/2013 01:50 PM, Anuj Phogat wrote: > On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: >> On 10/14/2013 10:12 AM, Anuj Phogat wrote: >>> @@ -789,6 +794,12 @@ builtin_variable_generator::generate_fs_special_vars() >>>if (state->AMD_shader_stencil_export_warn) >>> var->

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick wrote: > On 10/14/2013 10:12 AM, Anuj Phogat wrote: >> New builtins added by GL_ARB_sample_shading: >> in vec2 gl_SamplePosition >> in int gl_SampleID >> in int gl_NumSamples >> out int gl_SampleMask[] >> >> Signed-off-by: Anuj Phogat >> --- >> src/

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: > New builtins added by GL_ARB_sample_shading: > in vec2 gl_SamplePosition > in int gl_SampleID > in int gl_NumSamples > out int gl_SampleMask[] > > Signed-off-by: Anuj Phogat > --- > src/glsl/builtin_variables.cpp | 11 +++ > src/glsl/link_vary

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Ian Romanick
On 10/14/2013 10:12 AM, Anuj Phogat wrote: > New builtins added by GL_ARB_sample_shading: > in vec2 gl_SamplePosition > in int gl_SampleID > in int gl_NumSamples > out int gl_SampleMask[] > > Signed-off-by: Anuj Phogat > --- > src/glsl/builtin_variables.cpp | 11 +++ > src/glsl/link_vary

[Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-14 Thread Anuj Phogat
New builtins added by GL_ARB_sample_shading: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat --- src/glsl/builtin_variables.cpp | 11 +++ src/glsl/link_varyings.cpp | 2 ++ src/mesa/main/mtypes.h | 7 +