Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-08 Thread Timothy Arceri
On Sun, 2015-11-08 at 12:07 +, Emil Velikov wrote: > On 6 November 2015 at 21:13, Timothy Arceri wrote: > > On Fri, 2015-11-06 at 13:16 +, Emil Velikov wrote: > > > On 5 November 2015 at 11:17, Timothy Arceri > > > wrote: > > > > From: Timothy Arceri > > > > > > > > This is in preperati

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-08 Thread Emil Velikov
On 6 November 2015 at 21:13, Timothy Arceri wrote: > On Fri, 2015-11-06 at 13:16 +, Emil Velikov wrote: >> On 5 November 2015 at 11:17, Timothy Arceri wrote: >> > From: Timothy Arceri >> > >> > This is in preperation for compile-time constant support. >> typo "preparation" >> >> > >> > Also

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-06 Thread Timothy Arceri
On Fri, 2015-11-06 at 13:16 +, Emil Velikov wrote: > On 5 November 2015 at 11:17, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This is in preperation for compile-time constant support. > typo "preparation" > > > > > Also fix up the locations for some of the extension checking > >

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-06 Thread Emil Velikov
On 5 November 2015 at 11:17, Timothy Arceri wrote: > From: Timothy Arceri > > This is in preperation for compile-time constant support. typo "preparation" > > Also fix up the locations for some of the extension checking > error messages in the parser. We now correctly give the location > of the

[Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

2015-11-05 Thread Timothy Arceri
From: Timothy Arceri This is in preperation for compile-time constant support. Also fix up the locations for some of the extension checking error messages in the parser. We now correctly give the location of the layout qualifier identifier rather than the integer constant. The validation is mov