Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-21 Thread Rob Clark
On Thu, Mar 17, 2016 at 1:07 PM, Brian Paul wrote: > On 03/17/2016 10:47 AM, Nicolai Hähnle wrote: >> >> On 16.03.2016 19:43, Brian Paul wrote: >>> >>> The return type is float, which is what was implicitly used before, >>> AFAICT. >> >> >> Isn't this technically incorrect when the uploaded textur

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-21 Thread Nicolai Hähnle
On 17.03.2016 12:07, Brian Paul wrote: On 03/17/2016 10:47 AM, Nicolai Hähnle wrote: On 16.03.2016 19:43, Brian Paul wrote: The return type is float, which is what was implicitly used before, AFAICT. Isn't this technically incorrect when the uploaded texture is integer? That was my suspicio

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Nicolai Hähnle
On 16.03.2016 19:43, Brian Paul wrote: The return type is float, which is what was implicitly used before, AFAICT. Isn't this technically incorrect when the uploaded texture is integer? To be honest, it's not really clear to me what the return type is supposed to mean. I don't think any of th

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Brian Paul
On 03/17/2016 10:47 AM, Nicolai Hähnle wrote: On 16.03.2016 19:43, Brian Paul wrote: The return type is float, which is what was implicitly used before, AFAICT. Isn't this technically incorrect when the uploaded texture is integer? That was my suspicion, regardless of my patch. I'm not too

[Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Brian Paul
The return type is float, which is what was implicitly used before, AFAICT. --- src/mesa/state_tracker/st_cb_texture.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index bffa4d0..6ee55c6 100644 --- a/src/

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Nicolai Hähnle
On 17.03.2016 11:50, Ilia Mirkin wrote: On Thu, Mar 17, 2016 at 12:47 PM, Nicolai Hähnle wrote: On 16.03.2016 19:43, Brian Paul wrote: The return type is float, which is what was implicitly used before, AFAICT. Isn't this technically incorrect when the uploaded texture is integer? To be h

Re: [Mesa-dev] [PATCH 3/4] st/mesa: emit sampler view decls in PBO upload shader

2016-03-19 Thread Ilia Mirkin
On Thu, Mar 17, 2016 at 12:47 PM, Nicolai Hähnle wrote: > On 16.03.2016 19:43, Brian Paul wrote: >> >> The return type is float, which is what was implicitly used before, >> AFAICT. > > > Isn't this technically incorrect when the uploaded texture is integer? > > To be honest, it's not really clear