Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-08 Thread Brian Paul
On 01/08/2014 01:16 AM, Thomas Sondergaard wrote: On 08-01-2014 00:11, Brian Paul wrote: On 01/07/2014 03:30 PM, Ian Romanick wrote: On 01/07/2014 02:22 PM, Thomas Sondergaard wrote: On 2014-01-07 23:05, Ian Romanick wrote: On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: This small rearran

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-08 Thread Thomas Sondergaard
On 08-01-2014 00:11, Brian Paul wrote: On 01/07/2014 03:30 PM, Ian Romanick wrote: On 01/07/2014 02:22 PM, Thomas Sondergaard wrote: On 2014-01-07 23:05, Ian Romanick wrote: On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: This small rearrangement avoids MSVC 2013 ICE. Also, this should be a

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Thomas Sondergaard
On 2014-01-07 23:05, Ian Romanick wrote: On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better memory access order. Can you explain this better? As far as I can tell, this just changes the order the indices are visited (

[Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Thomas Sondergaard
This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better memory access order. --- src/gallium/drivers/softpipe/sp_quad_blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_quad_blend.c b/src/gallium/drivers/softpipe/sp

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Brian Paul
On 01/07/2014 03:30 PM, Ian Romanick wrote: On 01/07/2014 02:22 PM, Thomas Sondergaard wrote: On 2014-01-07 23:05, Ian Romanick wrote: On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better memory access order. Can you e

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Ian Romanick
On 01/07/2014 02:22 PM, Thomas Sondergaard wrote: > On 2014-01-07 23:05, Ian Romanick wrote: >> On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: >>> This small rearrangement avoids MSVC 2013 ICE. Also, this should be a >>> better >>> memory access order. >> >> Can you explain this better? As far

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Matt Turner
On Tue, Jan 7, 2014 at 2:05 PM, Ian Romanick wrote: > On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: >> This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better >> memory access order. > > Can you explain this better? As far as I can tell, this just changes > the order the

Re: [Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Ian Romanick
On 01/07/2014 12:31 PM, Thomas Sondergaard wrote: > This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better > memory access order. Can you explain this better? As far as I can tell, this just changes the order the indices are visited (and has a spurious, incorrect whitespace

[Mesa-dev] [PATCH 3/4] MSVC2013: Work around internal compiler error

2014-01-07 Thread Thomas Sondergaard
This small rearrangement avoids MSVC 2013 ICE. Also, this should be a better memory access order. --- src/gallium/drivers/softpipe/sp_quad_blend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_quad_blend.c b/src/gallium/drivers/softpipe/