Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-31 Thread Christian König
Am Dienstag, den 30.08.2011, 23:29 +0200 schrieb Maarten Lankhorst: > > I think the question we should ask isn't if one driver or another needs > > something, but more if one or another behaviour is specific to an > > interface or not. So when an interface theoretically allows a behaviour > > (even

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-30 Thread Maarten Lankhorst
Hey Christian, On 08/30/2011 12:05 PM, Christian König wrote: > Am Dienstag, den 30.08.2011, 00:11 +0200 schrieb Maarten Lankhorst: >> Hey Christian, >> >> On 08/29/2011 10:14 AM, Christian König wrote: >>> Am Sonntag, den 28.08.2011, 19:13 +0200 schrieb Maarten Lankhorst: Hey, On 0

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-30 Thread Christian König
Am Dienstag, den 30.08.2011, 00:11 +0200 schrieb Maarten Lankhorst: > Hey Christian, > > On 08/29/2011 10:14 AM, Christian König wrote: > > Am Sonntag, den 28.08.2011, 19:13 +0200 schrieb Maarten Lankhorst: > >> Hey, > >> > >> On 08/28/2011 05:04 PM, Christian König wrote: > >>> Hi Maarten, > >>>

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-29 Thread Maarten Lankhorst
Hey Christian, On 08/29/2011 10:14 AM, Christian König wrote: > Am Sonntag, den 28.08.2011, 19:13 +0200 schrieb Maarten Lankhorst: >> Hey, >> >> On 08/28/2011 05:04 PM, Christian König wrote: >>> Hi Maarten, >>> >>> could you put this into SetDecoderStatus instead? This makes the picture >>> struc

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-29 Thread Christian König
Am Sonntag, den 28.08.2011, 19:13 +0200 schrieb Maarten Lankhorst: > Hey, > > On 08/28/2011 05:04 PM, Christian König wrote: > > Hi Maarten, > > > > could you put this into SetDecoderStatus instead? This makes the picture > > structure also available in end_frame. > Erm it doesn't make sense there

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-28 Thread Maarten Lankhorst
Hey, On 08/28/2011 05:04 PM, Christian König wrote: > Hi Maarten, > > could you put this into SetDecoderStatus instead? This makes the picture > structure also available in end_frame. Erm it doesn't make sense there. It might make sense to move it to after the begin_frame though, but with interlac

Re: [Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-28 Thread Christian König
Hi Maarten, could you put this into SetDecoderStatus instead? This makes the picture structure also available in end_frame. Also named initializers shouldn't be used according to the coding rules. Christian. Am Sonntag, den 28.08.2011, 01:59 +0200 schrieb Maarten Lankhorst: > picture_structure

[Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

2011-08-27 Thread Maarten Lankhorst
picture_structure is needed to determine what type of picture this is Signed-off-by: Maarten Lankhorst --- src/gallium/state_trackers/xorg/xvmc/surface.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/state_trackers/xorg/xvmc/surface.c b/src/gallium/state_