Hey Christian, On 08/29/2011 10:14 AM, Christian König wrote: > Am Sonntag, den 28.08.2011, 19:13 +0200 schrieb Maarten Lankhorst: >> Hey, >> >> On 08/28/2011 05:04 PM, Christian König wrote: >>> Hi Maarten, >>> >>> could you put this into SetDecoderStatus instead? This makes the picture >>> structure also available in end_frame. >> Erm it doesn't make sense there. It might make sense to move it to after >> the begin_frame though, but with interlaced frames I don't see why you >> would want to move it into SetDecoderStatus, since you could have interlaced >> frames with different picture_structures. > Oh, what I wanted to say is: Remember the picture structure in use when > begin_frame is called and just set it to the same value when end_frame > is called. Also having a end_frame/begin_frame when the picture > structure changes from top to bottom (or the other way around) couldn't > hurt also. > The nouveau decoder doesn't need to remember the picture structure, it only needs it during the render call. If vl_mpeg12_decoder needs it, wouldn't it make more sense to remember it in the vl_mpeg12_buffer?
Also I think it's safe to assume that the picture_structure won't change, since the mpeg spec assumes its constant for the entire frame. ~Maarten _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
