Re: [Mesa-dev] [PATCH 25/30] mesa/main: split float-texture support checking in two

2018-11-19 Thread Erik Faye-Lund
On Mon, 2018-11-19 at 18:43 +0100, Francesco Ansanelli wrote: > Hi Eric, > > While checking this patch I noticed an extra semicolon in this > function: > +static inline bool > +_mesa_has_half_float_textures(const struct gl_context *ctx) > +{ > + return _mesa_has_ARB_texture_float(ctx) || > +

[Mesa-dev] [PATCH 25/30] mesa/main: split float-texture support checking in two

2018-11-19 Thread Erik Faye-Lund
On OpenGL ES 2.0, there's separate extensions adding support for half-float and float textures. So we need to validate the enums separately as well. This also prevents these enums from incorrectly being allowed on OpenGL ES 1.x, where there's no extension that enables this in the first place. Sig