v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3: Revie
On 02/02/15 16:09, Ilia Mirkin wrote:
On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
wrote:
+static struct gl_transform_feedback_object *
+_mesa_lookup_transform_feedback_object_err(struct gl_context *ctx,
+ GLuint xfb, const char* func)
+{
+ struct gl
On 02/02/15 23:46, Laura Ekstrand wrote:
On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres
mailto:martin.pe...@linux.intel.com>>
wrote:
@@ -543,15 +545,12 @@ bind_buffer_range(struct gl_context *ctx,
GLuint index,
*/
void
_mesa_bind_buffer_range_transform_feedback(struct
On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - give more helpful error messages
> - factor the lookup code for the xfb and objBuf
> - replace some already-existing tabs with spaces
> - add comments to explain the cases where xfb == 0 or buffer == 0
> - fi
Oops, what I meant to say was "Make the bufferobj lookup function static."
The lookup transform feedback function doesn't have to be static.
On Mon, Feb 2, 2015 at 6:09 AM, Ilia Mirkin wrote:
> On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
> wrote:
> > +static struct gl_transform_feedback_object
On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres
wrote:
> +static struct gl_transform_feedback_object *
> +_mesa_lookup_transform_feedback_object_err(struct gl_context *ctx,
> + GLuint xfb, const char* func)
> +{
> + struct gl_transform_feedback_object *obj;
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3: Revie
On Thu, Jan 29, 2015 at 4:55 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - give more helpful error messages
> - factor the lookup code for the xfb and objBuf
> - replace some already-existing tabs with spaces
> - add comments to explain the cases where xfb == 0 or buffer == 0
> - f
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
Signed-of
