Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Timothy Arceri
On Sun, 2014-11-09 at 07:48 +0330, Siavash Eliasi wrote: > I know that's a time saver for developer (gcc function multi > versioning), however I still do prefer the approach (my own ^^ ) which > works on all setups regardless of hardware and compiler (well, any sane > compiler ICC, GCC, Clang,..

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Timothy Arceri
On Sun, 2014-11-09 at 08:59 +1100, Timothy Arceri wrote: > On Sat, 2014-11-08 at 18:13 +, Emil Velikov wrote: > > On 08/11/14 11:12, Timothy Arceri wrote: > > > Signed-off-by: Timothy Arceri > > As long as it fixes odd combinations such as this the following I'm all > > in favour of using such

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Siavash Eliasi
I know that's a time saver for developer (gcc function multi versioning), however I still do prefer the approach (my own ^^ ) which works on all setups regardless of hardware and compiler (well, any sane compiler ICC, GCC, Clang,...). Best regards, Siavash Eliasi. _

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Timothy Arceri
On Sat, 2014-11-08 at 16:29 +0330, Siavash Eliasi wrote: > I rather to not use compiler specific hacks in mesa. If it was a > personal pet project it would make sense. > > Best regards, > Siavash Eliasi. Having to work around compiler differences is a real world problem. As has been pointed out

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Timothy Arceri
On Sat, 2014-11-08 at 18:13 +, Emil Velikov wrote: > On 08/11/14 11:12, Timothy Arceri wrote: > > Signed-off-by: Timothy Arceri > As long as it fixes odd combinations such as this the following I'm all > in favour of using such an approach. It will save us quite a few > "lovely" details - spli

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Emil Velikov
On 08/11/14 11:12, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri As long as it fixes odd combinations such as this the following I'm all in favour of using such an approach. It will save us quite a few "lovely" details - split the file, configure checks etc... https://bugs.freedesktop.org

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Matt Turner
On Sat, Nov 8, 2014 at 4:59 AM, Siavash Eliasi wrote: > I rather to not use compiler specific hacks in mesa. If it was a personal > pet project it would make sense. We use compiler-specific things all the time. That's not going to change. ___ mesa-dev m

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Siavash Eliasi
I rather to not use compiler specific hacks in mesa. If it was a personal pet project it would make sense. Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- src/mesa/x86/x86_function_opt.h | 42 + 1 file changed, 42 insertions(+) create mode 100644 src/mesa/x86/x86_function_opt.h Using a macro like this means we can easily enable runtime support in clang once it also suppor