On Sun, 2014-11-09 at 08:59 +1100, Timothy Arceri wrote: > On Sat, 2014-11-08 at 18:13 +0000, Emil Velikov wrote: > > On 08/11/14 11:12, Timothy Arceri wrote: > > > Signed-off-by: Timothy Arceri <t_arc...@yahoo.com.au> > > As long as it fixes odd combinations such as this the following I'm all > > in favour of using such an approach. It will save us quite a few > > "lovely" details - split the file, configure checks etc... > > > > https://bugs.freedesktop.org/show_bug.cgi?id=71547 > > > Hmmm, what a pain. I'm not sure what "GCC target" will do in this case, > will need to check.
ok, so for the intel driver it doesn't build with this type of setup anyway as intel_mipmap_tree.c still uses #if defined(USE_SSE41) you end up with undefined symbol: _mesa_streaming_load_memcpy at runtime. Once I removed the calls to _mesa_streaming_load_memcpy is seems GCC target overrides the no-ssse3 flag so it seems it will be fine as long as a runtime check is in place. > > It will be a shame if we can't enable these optimisations just because > people wish to build in this way. > > > > > Just a small nit below :) > > > > Thanks > > Emil > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
