Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-03 Thread Nanley Chery
On Fri, Feb 03, 2017 at 12:27:18PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > > On Thu, Feb 2, 2017 at 10:55 AM,

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-03 Thread Jason Ekstrand
On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery > wrote: > > > > > > > On Wed, Feb 01, 2017 at 10:11:42PM -0

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Nanley Chery
On Thu, Feb 02, 2017 at 03:10:21PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery > > wrote: > > > > > > > On Thu, Feb 02, 2017 at 01:37:56

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Jason Ekstrand
On Thu, Feb 2, 2017 at 3:01 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery > wrote: > > > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > > > On Thu, Feb 02, 2017 at 12:53:33PM -0800

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Nanley Chery
On Thu, Feb 02, 2017 at 01:55:30PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > > On Thu, Feb 2, 2017 at 10:55 AM,

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Jason Ekstrand
On Thu, Feb 2, 2017 at 1:45 PM, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery > wrote: > > > > > > > On Wed, Feb 01, 2017 at 10:11:42PM -0

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Nanley Chery
On Thu, Feb 02, 2017 at 01:37:56PM -0800, Nanley Chery wrote: > On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > > > > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > > > This improves the performance

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Nanley Chery
On Thu, Feb 02, 2017 at 12:53:33PM -0800, Jason Ekstrand wrote: > On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > > > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > > machine by about 2-3%. > > >

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Jason Ekstrand
On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > --- > > src/intel/vulkan/anv_private.h | 1 + > > src/intel/vulkan/g

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Jason Ekstrand
On Thu, Feb 2, 2017 at 10:55 AM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > > machine by about 2-3%. > > --- > > src/intel/vulkan/anv_private.h | 1 + > > src/intel/vulkan/g

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Nanley Chery
On Wed, Feb 01, 2017 at 10:11:42PM -0800, Jason Ekstrand wrote: > This improves the performance of Dota 2 on my Sky Lake Skull Canyon > machine by about 2-3%. > --- > src/intel/vulkan/anv_private.h | 1 + > src/intel/vulkan/gen8_cmd_buffer.c | 155 > - >

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Jason Ekstrand
On Thu, Feb 2, 2017 at 3:49 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Reviewed-by: Lionel Landwerlin > > > The documentation has the following sentence for both CACHE_MODE_0 & > CACHE_MODE_1 > : > > "Before changing the value of this register, GFX pipeline must be idle > i

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-02 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin The documentation has the following sentence for both CACHE_MODE_0 & CACHE_MODE_1 : "Before changing the value of this register, GFX pipeline must be idle i.e. full flush is required." That seems coherent with a command stream stall. On 02/02/17 06:11,

[Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

2017-02-01 Thread Jason Ekstrand
This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 155 - src/intel/vulkan/genX_pipeline.c | 6 +- 3 files changed, 156 insertions(+)