Re: [Mesa-dev] [PATCH 2/2] Don't use -fvisibilty=hidden on cygwin

2011-04-27 Thread Dan Nicholson
On Wed, Apr 27, 2011 at 4:06 AM, Jon TURNEY wrote: > On 27/04/2011 11:39, Dan Nicholson wrote: >> On Tue, Apr 26, 2011 at 5:00 AM, Jon TURNEY wrote: >>> Alternatively, the configuration check could be made more complex to avoid >>> using this flag is the target isn't ELF or using the flag generate

Re: [Mesa-dev] [PATCH 2/2] Don't use -fvisibilty=hidden on cygwin

2011-04-27 Thread Jon TURNEY
On 27/04/2011 11:39, Dan Nicholson wrote: > On Tue, Apr 26, 2011 at 5:00 AM, Jon TURNEY wrote: >> Alternatively, the configuration check could be made more complex to avoid >> using this flag is the target isn't ELF or using the flag generates a warning > > You could add -Werror to the CFLAGS used

Re: [Mesa-dev] [PATCH 2/2] Don't use -fvisibilty=hidden on cygwin

2011-04-27 Thread Dan Nicholson
On Tue, Apr 26, 2011 at 5:00 AM, Jon TURNEY wrote: > Using -fvisibility=hidden makes the current cygwin gcc emit a warning > "warning: visibility attribute not supported in this configuration; ignored" > for every single non-static symbol > > $ make clean && make 2>&1 | grep "ignored" | wc -l > 64

[Mesa-dev] [PATCH 2/2] Don't use -fvisibilty=hidden on cygwin

2011-04-26 Thread Jon TURNEY
Using -fvisibility=hidden makes the current cygwin gcc emit a warning "warning: visibility attribute not supported in this configuration; ignored" for every single non-static symbol $ make clean && make 2>&1 | grep "ignored" | wc -l 6457 This is pretty annoying and makes it hard to spot other err