Re: [Mesa-dev] [PATCH 12/18] i965: Drop use of intel_region from miptrees.

2014-05-01 Thread Chad Versace
On Tue, Apr 29, 2014 at 04:34:37PM -0700, Eric Anholt wrote: > Note: region->width used to reflect the total_width/height padding of > separate stencil, and mt->total_width doesn't. The note scares me. It tells me the patch has a known, potential bug regarding stencil buffers... but after some di

Re: [Mesa-dev] [PATCH 12/18] i965: Drop use of intel_region from miptrees.

2014-04-30 Thread Kenneth Graunke
On 04/29/2014 04:34 PM, Eric Anholt wrote: [snip] > @@ -319,13 +319,15 @@ gen7_update_texture_surface(struct gl_context *ctx, > if (mt->array_spacing_lod0) >surf[0] |= GEN7_SURFACE_ARYSPC_LOD0; > > - surf[1] = mt->region->bo->offset64 + mt->offset; /* reloc */ > + surf[1] = mt->bo