Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-14 Thread Jason Ekstrand
On Wed, Jan 14, 2015 at 2:34 PM, Connor Abbott wrote: > On Wed, Jan 14, 2015 at 5:15 PM, Jason Ekstrand > wrote: > > > > > > On Sun, Jan 11, 2015 at 7:08 PM, Connor Abbott > wrote: > >> > >> On Tue, Jan 6, 2015 at 5:21 PM, Jason Ekstrand > >> wrote: > >> > > >> > > >> > On Mon, Jan 5, 2015 at

Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-14 Thread Connor Abbott
On Wed, Jan 14, 2015 at 5:15 PM, Jason Ekstrand wrote: > > > On Sun, Jan 11, 2015 at 7:08 PM, Connor Abbott wrote: >> >> On Tue, Jan 6, 2015 at 5:21 PM, Jason Ekstrand >> wrote: >> > >> > >> > On Mon, Jan 5, 2015 at 10:00 PM, Jason Ekstrand >> > wrote: >> >> >> >> >> >> >> >> On Mon, Jan 5, 201

Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-14 Thread Jason Ekstrand
On Sun, Jan 11, 2015 at 7:08 PM, Connor Abbott wrote: > On Tue, Jan 6, 2015 at 5:21 PM, Jason Ekstrand > wrote: > > > > > > On Mon, Jan 5, 2015 at 10:00 PM, Jason Ekstrand > > wrote: > >> > >> > >> > >> On Mon, Jan 5, 2015 at 9:12 PM, Connor Abbott > wrote: > >>> > >>> Hi, > >>> > >>> Was it y

Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-11 Thread Connor Abbott
On Tue, Jan 6, 2015 at 5:21 PM, Jason Ekstrand wrote: > > > On Mon, Jan 5, 2015 at 10:00 PM, Jason Ekstrand > wrote: >> >> >> >> On Mon, Jan 5, 2015 at 9:12 PM, Connor Abbott wrote: >>> >>> Hi, >>> >>> Was it your intention to not support non-per-component things like dot >>> product at all? I'v

Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-06 Thread Jason Ekstrand
On Mon, Jan 5, 2015 at 10:00 PM, Jason Ekstrand wrote: > > > On Mon, Jan 5, 2015 at 9:12 PM, Connor Abbott wrote: > >> Hi, >> >> Was it your intention to not support non-per-component things like dot >> product at all? I've made a few inline comments about how to do it, >> and it doesn't seem li

Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-05 Thread Jason Ekstrand
On Mon, Jan 5, 2015 at 9:12 PM, Connor Abbott wrote: > Hi, > > Was it your intention to not support non-per-component things like dot > product at all? I've made a few inline comments about how to do it, > and it doesn't seem like it's that hard. > No, It was just never tested on them. All your

Re: [Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2015-01-05 Thread Connor Abbott
Hi, Was it your intention to not support non-per-component things like dot product at all? I've made a few inline comments about how to do it, and it doesn't seem like it's that hard. On Tue, Dec 16, 2014 at 1:12 AM, Jason Ekstrand wrote: > > This framework provides a simple way to do simple sea

[Mesa-dev] [PATCH 110/133] nir: Add an expression matching framework

2014-12-15 Thread Jason Ekstrand
This framework provides a simple way to do simple search-and-replace operations on NIR code. The nir_search.h header provides four simple data structures for representing expressions: nir_value and four subtypes: nir_variable, nir_constant, and nir_expression. An expression tree can then be repr