Re: [Mesa-dev] [PATCH 11/17] intel/compiler/fs: Simplify ddx/ddy code generation

2018-02-26 Thread Matt Turner
On Fri, Feb 23, 2018 at 4:37 PM, Kenneth Graunke wrote: > On Tuesday, February 20, 2018 9:15:18 PM PST Matt Turner wrote: >> The brw_reg() constructor just obfuscates things here, in my opinion. >> --- >> src/intel/compiler/brw_fs_generator.cpp | 77 >> +++-- >> 1 fil

Re: [Mesa-dev] [PATCH 11/17] intel/compiler/fs: Simplify ddx/ddy code generation

2018-02-23 Thread Kenneth Graunke
On Tuesday, February 20, 2018 9:15:18 PM PST Matt Turner wrote: > The brw_reg() constructor just obfuscates things here, in my opinion. > --- > src/intel/compiler/brw_fs_generator.cpp | 77 > +++-- > 1 file changed, 35 insertions(+), 42 deletions(-) > > diff --git a/s

[Mesa-dev] [PATCH 11/17] intel/compiler/fs: Simplify ddx/ddy code generation

2018-02-20 Thread Matt Turner
The brw_reg() constructor just obfuscates things here, in my opinion. --- src/intel/compiler/brw_fs_generator.cpp | 77 +++-- 1 file changed, 35 insertions(+), 42 deletions(-) diff --git a/src/intel/compiler/brw_fs_generator.cpp b/src/intel/compiler/brw_fs_generator.c