[Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-20 Thread Marek Olšák
From: Marek Olšák This is needed for exposing the samplerBuffer functions under EXT_gpu_shader4. v2: - expose it in the compat profile only - make it an alias of EXT_gpu_shader4 Reviewed-by: Timothy Arceri (v1) --- docs/relnotes/18.3.0.html| 1 + src/mesa/main/extensions_table.h |

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-20 Thread Marek Olšák
On Mon, Aug 13, 2018 at 12:58 PM Ian Romanick wrote: > > On 08/10/2018 08:14 PM, Marek Olšák wrote: > > On Fri, Aug 10, 2018 at 9:04 PM, Ian Romanick wrote: > >> On 08/07/2018 10:42 PM, Marek Olšák wrote: > >>> From: Marek Olšák > >>> > >>> This is needed for exposing the samplerBuffer functions

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-13 Thread Ian Romanick
On 08/10/2018 08:14 PM, Marek Olšák wrote: > On Fri, Aug 10, 2018 at 9:04 PM, Ian Romanick wrote: >> On 08/07/2018 10:42 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This is needed for exposing the samplerBuffer functions under >>> EXT_gpu_shader4. >>> >>> glTexBufferEXT is defined in gla

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-10 Thread Marek Olšák
On Fri, Aug 10, 2018 at 9:04 PM, Ian Romanick wrote: > On 08/07/2018 10:42 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under >> EXT_gpu_shader4. >> >> glTexBufferEXT is defined in glapi, but "make check" fails. >> What am I doing wrong

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-10 Thread Ian Romanick
On 08/07/2018 10:42 PM, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What am I doing wrong? > --- > docs/relnotes/18.3.0.html | 1 + > s

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 17:29, Marek Olšák wrote: > On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov > wrote: >> On 8 August 2018 at 12:04, Emil Velikov wrote: >>> On 8 August 2018 at 06:42, Marek Olšák wrote: From: Marek Olšák This is needed for exposing the samplerBuffer functions u

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov wrote: > On 8 August 2018 at 12:04, Emil Velikov wrote: >> On 8 August 2018 at 06:42, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This is needed for exposing the samplerBuffer functions under >>> EXT_gpu_shader4. >>> >>> glTexBufferEXT is defin

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Dylan Baker
Quoting Emil Velikov (2018-08-08 04:04:51) > On 8 August 2018 at 06:42, Marek Olšák wrote: > > From: Marek Olšák > > > > This is needed for exposing the samplerBuffer functions under > > EXT_gpu_shader4. > > > > glTexBufferEXT is defined in glapi, but "make check" fails. > > What am I doing wrong

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 12:04, Emil Velikov wrote: > On 8 August 2018 at 06:42, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under >> EXT_gpu_shader4. >> >> glTexBufferEXT is defined in glapi, but "make check" fails. >> What am I doing wrong?

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
Thanks. I'll remove the dispatch_sanity change. Marek On Wed, Aug 8, 2018 at 12:07 PM, Ilia Mirkin wrote: > It's not the alias itself that breaks it -- but you can only have one > entry per alias group. > > On Wed, Aug 8, 2018 at 12:03 PM, Marek Olšák wrote: >> Yes, it's aliased. It's weird, be

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Ilia Mirkin
It's not the alias itself that breaks it -- but you can only have one entry per alias group. On Wed, Aug 8, 2018 at 12:03 PM, Marek Olšák wrote: > Yes, it's aliased. It's weird, because adding other aliased functions > into dispatch_sanity didn't break the test. > > Marek > > On Wed, Aug 8, 2018

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
Yes, it's aliased. It's weird, because adding other aliased functions into dispatch_sanity didn't break the test. Marek On Wed, Aug 8, 2018 at 12:00 PM, Ilia Mirkin wrote: > Sorry, I thought I was answering your question. > > If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which >

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Ilia Mirkin
Sorry, I thought I was answering your question. If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which are already in the list of dispatch functions, you should not add the aliased name, otherwise you'll get failures. I did not, however, check if glTexBufferEXT is aliased in the disp

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
What does that mean? Marek On Wed, Aug 8, 2018 at 9:05 AM, Ilia Mirkin wrote: > Aliased functions shouldn't be added separately to the function list. > > On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Ilia Mirkin
Aliased functions shouldn't be added separately to the function list. On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 06:42, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What am I doing wrong? There should be one in src/mapi/glapi/gen/ One of these d

[Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-07 Thread Marek Olšák
From: Marek Olšák This is needed for exposing the samplerBuffer functions under EXT_gpu_shader4. glTexBufferEXT is defined in glapi, but "make check" fails. What am I doing wrong? --- docs/relnotes/18.3.0.html | 1 + src/mesa/main/extensions_table.h| 1 + src/mesa/main/tes