Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-09 Thread Chad Versace
On Mon, 06 Jun 2011 18:56:20 -0700, Kenneth Graunke wrote: > On 06/04/2011 05:45 PM, Chad Versace wrote: > > When it is sensible to do so, > > 1) intelCreateBuffer() now attaches separate depth and stencil > > buffers > > to the framebuffer it creates. > > 2) intel_updat

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-09 Thread Chad Versace
On Tue, 07 Jun 2011 08:15:51 -0700, Kenneth Graunke wrote: > On 06/07/2011 01:33 AM, Julien Cristau wrote: > > On Mon, Jun 6, 2011 at 18:56:20 -0700, Kenneth Graunke wrote: > > > >> I'd make this an assertion. must_use_separate_stencil is only set for > >> gen>= 7, and I assert that try_separat

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-07 Thread Kenneth Graunke
On 06/07/2011 01:33 AM, Julien Cristau wrote: On Mon, Jun 6, 2011 at 18:56:20 -0700, Kenneth Graunke wrote: I'd make this an assertion. must_use_separate_stencil is only set for gen>= 7, and I assert that try_separate_stencil ought to be true in that case (old DDX doesn't support IVB, new DDX

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-07 Thread Julien Cristau
On Mon, Jun 6, 2011 at 18:56:20 -0700, Kenneth Graunke wrote: > I'd make this an assertion. must_use_separate_stencil is only set for > gen >= 7, and I assert that try_separate_stencil ought to be true in > that case (old DDX doesn't support IVB, new DDX requires new dri2proto > to compile

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-06 Thread Kenneth Graunke
On 06/04/2011 05:45 PM, Chad Versace wrote: When it is sensible to do so, 1) intelCreateBuffer() now attaches separate depth and stencil buffers to the framebuffer it creates. 2) intel_update_renderbuffers() requests for the framebuffer a separate stencil buffer

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-05 Thread Chad Versace
On Sun, 5 Jun 2011 11:01:21 +0200, Nicolas Kaiser wrote: > Just noticed two typos in comments. > > * Chad Versace : > > --- a/src/mesa/drivers/dri/intel/intel_context.c > > +++ b/src/mesa/drivers/dri/intel/intel_context.c > (..) > > +/** > > + * \brief Verify that the X driver supports hiz and se

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-05 Thread Nicolas Kaiser
Just noticed two typos in comments. * Chad Versace : > --- a/src/mesa/drivers/dri/intel/intel_context.c > +++ b/src/mesa/drivers/dri/intel/intel_context.c (..) > +/** > + * \brief Verify that the X driver supports hiz and separate stencil. > + * > + * This implements the cleanup stage of the hands

[Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

2011-06-04 Thread Chad Versace
When it is sensible to do so, 1) intelCreateBuffer() now attaches separate depth and stencil buffers to the framebuffer it creates. 2) intel_update_renderbuffers() requests for the framebuffer a separate stencil buffer (DRI2BufferStencil). The criteria for "sensible" i