Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-22 Thread Julien Isorce
On 21 December 2015 at 15:10, Christian König wrote: > On 21.12.2015 11:05, Andy Furniss wrote: > >> Julien Isorce wrote: >> >>> Hi Christian, >>> >>> I have 2 remarks: >>> >>> 1: I am sure you have the clear answer to the following questions, so >>> maybe add a comment in the commit message: Isn

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-21 Thread Andy Furniss
Christian König wrote: Slightly unrelated question = with vaapi using mpeg2 do you get the same result as vdpau or s/w? Well MPEG2 actually defines that the resulting image doesn't need to be 100% bit identical on all decoders. H.264 and others are way more strict regarding this. Do you also

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-21 Thread Christian König
On 21.12.2015 11:05, Andy Furniss wrote: Julien Isorce wrote: Hi Christian, I have 2 remarks: 1: I am sure you have the clear answer to the following questions, so maybe add a comment in the commit message: Isn't the thread safety delegated to the application that use vaapi ? like it is design

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-21 Thread Andy Furniss
Julien Isorce wrote: Hi Christian, I have 2 remarks: 1: I am sure you have the clear answer to the following questions, so maybe add a comment in the commit message: Isn't the thread safety delegated to the application that use vaapi ? like it is designed for many libraries. I tried to find ans

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-21 Thread Julien Isorce
Hi Christian, I have 2 remarks: 1: I am sure you have the clear answer to the following questions, so maybe add a comment in the commit message: Isn't the thread safety delegated to the application that use vaapi ? like it is designed for many libraries. I tried to find answer in vaapi-intel-driv

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-18 Thread Emil Velikov
Hi Christian, I've just sent a few comments/suggestions. With or without the nitpicks (but the remaining addressed) the series is Reviewed-by: Emil Velikov Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.or

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-18 Thread Emil Velikov
Hi Christian, An alternative solution would be to refcount on handle_table_get/put (first we need the latter even :-P) although I think that route will be longer (i.e. larger patch). Just thinking out loud, than a suggestion really. On 16 December 2015 at 20:14, Christian König wrote: > @@ -165

Re: [Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-16 Thread Michel Dänzer
Typo in the subject: "save" => "safe" -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://

[Mesa-dev] [PATCH 1/9] st/va: make the implementation thread save

2015-12-16 Thread Christian König
From: Christian König Otherwise we might crash with MPV. Signed-off-by: Christian König --- src/gallium/state_trackers/va/buffer.c | 69 +- src/gallium/state_trackers/va/context.c| 6 +++ src/gallium/state_trackers/va/image.c | 68 +