Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-16 Thread Timothy Arceri
On Tue, 2015-12-15 at 22:44 -0800, Jason Ekstrand wrote: > On Dec 14, 2015 3:34 PM, "Ian Romanick" wrote: > > > > From: Ian Romanick > > > > nir/nir.h: In function 'nir_src_for_ssa': > > nir/nir.h:552:4: warning: missing initializer for field 'use_link' > of 'nir_src' > > [-Wmissing-field-initial

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-16 Thread Kenneth Graunke
On Monday, December 14, 2015 03:34:25 PM Ian Romanick wrote: > From: Ian Romanick > > nir/nir.h: In function 'nir_src_for_ssa': > nir/nir.h:552:4: warning: missing initializer for field 'use_link' of > 'nir_src' > [-Wmissing-field-initializers] > nir_src src = NIR_SRC_INIT; > ^ > In file

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-15 Thread Jason Ekstrand
On Dec 14, 2015 3:34 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > nir/nir.h: In function 'nir_src_for_ssa': > nir/nir.h:552:4: warning: missing initializer for field 'use_link' of 'nir_src' > [-Wmissing-field-initializers] > nir_src src = NIR_SRC_INIT; > ^ > In file included from

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-15 Thread Ian Romanick
On 12/14/2015 07:36 PM, Jason Ekstrand wrote: > On Mon, Dec 14, 2015 at 5:12 PM, Ian Romanick wrote: >> On 12/14/2015 04:39 PM, Ilia Mirkin wrote: >>> On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: On 12/14/2015 03:38 PM, Ilia Mirkin wrote: > It's a pretty standard feature of compi

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-14 Thread Jason Ekstrand
On Mon, Dec 14, 2015 at 5:12 PM, Ian Romanick wrote: > On 12/14/2015 04:39 PM, Ilia Mirkin wrote: >> On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: >>> On 12/14/2015 03:38 PM, Ilia Mirkin wrote: It's a pretty standard feature of compilers to init things to 0 and not have the full

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-14 Thread Ian Romanick
On 12/14/2015 04:39 PM, Ilia Mirkin wrote: > On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: >> On 12/14/2015 03:38 PM, Ilia Mirkin wrote: >>> It's a pretty standard feature of compilers to init things to 0 and >>> not have the full structure specified like that... what compiler are >>> you s

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-14 Thread Ilia Mirkin
On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: > On 12/14/2015 03:38 PM, Ilia Mirkin wrote: >> It's a pretty standard feature of compilers to init things to 0 and >> not have the full structure specified like that... what compiler are >> you seeing these with? Can we just fix the glitch with

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-14 Thread Ian Romanick
On 12/14/2015 03:38 PM, Ilia Mirkin wrote: > It's a pretty standard feature of compilers to init things to 0 and > not have the full structure specified like that... what compiler are > you seeing these with? Can we just fix the glitch with a > -Wno-stupid-warnings? I have observed this with sever

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-14 Thread Ilia Mirkin
It's a pretty standard feature of compilers to init things to 0 and not have the full structure specified like that... what compiler are you seeing these with? Can we just fix the glitch with a -Wno-stupid-warnings? On Mon, Dec 14, 2015 at 6:34 PM, Ian Romanick wrote: > From: Ian Romanick > > ni

[Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

2015-12-14 Thread Ian Romanick
From: Ian Romanick nir/nir.h: In function 'nir_src_for_ssa': nir/nir.h:552:4: warning: missing initializer for field 'use_link' of 'nir_src' [-Wmissing-field-initializers] nir_src src = NIR_SRC_INIT; ^ In file included from nir/nir.c:28:0: nir/nir.h:508:21: note: 'use_link' declared here