Re: [Mesa-dev] [PATCH 1/6] glsl: Remove useless iteration through function parameters.

2013-11-23 Thread Ian Romanick
Patches 1 through 4 and 6 are Reviewed-by: Ian Romanick I had a question about 5. On 11/23/2013 01:43 PM, Kenneth Graunke wrote: > There's no need to loop through the "parameters" list and remove every > element; move_nodes_to(¶meters) already throws away all elements of > the destination list.

[Mesa-dev] [PATCH 1/6] glsl: Remove useless iteration through function parameters.

2013-11-23 Thread Kenneth Graunke
There's no need to loop through the "parameters" list and remove every element; move_nodes_to(¶meters) already throws away all elements of the destination list. Signed-off-by: Kenneth Graunke --- src/glsl/ir.cpp | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/