[Mesa-dev] [PATCH 1/6] glsl: Remove useless iteration through function parameters.

[Kenneth Graunke]

There's no need to loop through the "parameters" list and remove every
element; move_nodes_to(&parameters) already throws away all elements of
the destination list.

Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
---
 src/glsl/ir.cpp | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp
index ffff297..3be7d51 100644
--- a/src/glsl/ir.cpp
+++ b/src/glsl/ir.cpp
@@ -1729,12 +1729,6 @@ ir_function_signature::replace_parameters(exec_list 
*new_params)
     * parameter information comes from the function prototype, it may either
     * specify incorrect parameter names or not have names at all.
     */
-   foreach_iter(exec_list_iterator, iter, parameters) {
-      assert(((ir_instruction *) iter.get())->as_variable() != NULL);
-
-      iter.remove();
-   }
-
    new_params->move_nodes_to(&parameters);
 }
 
-- 
1.8.4.4

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev