Re: [Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

Hey Kenneth, Kenneth Graunke wrote on 16.05.2016 08:58: > On Monday, May 9, 2016 5:42:28 PM PDT Kai Wasserbäch wrote: >> while hunting the cause of fdo#95285 down, I tested these patches from your >> tombraider-2 branch. But when applied the game started crashing, see >>

Re: [Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

On Monday, May 9, 2016 5:42:28 PM PDT Kai Wasserbäch wrote: > Hey Kenneth, > while hunting the cause of fdo#95285 down, I tested these patches from your > tombraider-2 branch. But when applied the game started crashing, see > . Now, it might be

Re: [Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > The pass ultimately skips over any entries with assignment_count != 1, > so there's no need to do further work once we've determined that there > are multiple assignments. > > The constant value could be a large array (i.e. uvec4[327]), at which > p

Re: [Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

Hey Kenneth, while hunting the cause of fdo#95285 down, I tested these patches from your tombraider-2 branch. But when applied the game started crashing, see . Now, it might be that the omitted "glsl: Make lower_const_arrays_to_uniforms work di

[Mesa-dev] [PATCH 1/5] glsl: Make opt_constant_variable() bail in useless cases.

The pass ultimately skips over any entries with assignment_count != 1, so there's no need to do further work once we've determined that there are multiple assignments. The constant value could be a large array (i.e. uvec4[327]), at which point skipping the constant_expression_value() call (and the