Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-28 Thread Marek Olšák
On Thu, Apr 27, 2017 at 4:57 PM, Emil Velikov wrote: > On 27 April 2017 at 11:52, Constantine Kharlamov wrote: >> 27.04.2017, 13:26, "Emil Velikov" : >>> Hi Constantine, >>> >>> I'm not familiar with r600, so mostly a drive-by idea/nit. >> >> I'm not familiar with graphics :P Well, perhaps a litt

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-27 Thread Emil Velikov
On 27 April 2017 at 11:52, Constantine Kharlamov wrote: > 27.04.2017, 13:26, "Emil Velikov" : >> Hi Constantine, >> >> I'm not familiar with r600, so mostly a drive-by idea/nit. > > I'm not familiar with graphics :P Well, perhaps a little now. > >> On 25 April 2017 at 12:59, Constantine Kharlamov

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-27 Thread Constantine Kharlamov
27.04.2017, 13:26, "Emil Velikov" : > Hi Constantine, > > I'm not familiar with r600, so mostly a drive-by idea/nit. I'm not familiar with graphics :P Well, perhaps a little now. > On 25 April 2017 at 12:59, Constantine Kharlamov wrote: > >>  @@ -1746,45 +1747,47 @@ static void evergreen_emit_fr

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-27 Thread Emil Velikov
Hi Constantine, I'm not familiar with r600, so mostly a drive-by idea/nit. On 25 April 2017 at 12:59, Constantine Kharlamov wrote: > @@ -1746,45 +1747,47 @@ static void evergreen_emit_framebuffer_state(struct > r600_context *rctx, struct r > radeon_set_context_reg(cs, R_028E50_

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-27 Thread Marc Dietrich
Am Mittwoch, 26. April 2017, 19:48:46 CEST schrieb Constantine Kharlamov: > On 26.04.2017 17:51, Marc Dietrich wrote: > > Am Mittwoch, 26. April 2017, 16:36:39 CEST schrieb Constantine Kharlamov: > >> HEAD recently have triggered a bug in sb compiler, so, just for the safe > >> case, can you tell i

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Constantine Kharlamov
On 26.04.2017 17:51, Marc Dietrich wrote: > Am Mittwoch, 26. April 2017, 16:36:39 CEST schrieb Constantine Kharlamov: >> HEAD recently have triggered a bug in sb compiler, so, just for the safe >> case, can you tell if reverting this commit >> >> git revert --no-commit eb8aa93c03ee89ffd3041d41b6293

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Marc Dietrich
Am Mittwoch, 26. April 2017, 16:36:39 CEST schrieb Constantine Kharlamov: > HEAD recently have triggered a bug in sb compiler, so, just for the safe > case, can you tell if reverting this commit > > git revert --no-commit eb8aa93c03ee89ffd3041d41b6293e4b282b6ce6 > > but having my patch still appl

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Constantine Kharlamov
HEAD recently have triggered a bug in sb compiler, so, just for the safe case, can you tell if reverting this commit git revert --no-commit eb8aa93c03ee89ffd3041d41b6293e4b282b6ce6 but having my patch still applied changes anything or not? (I have this commit reverted locally) On 26.04.2017 17

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Marc Dietrich
Am Mittwoch, 26. April 2017, 16:16:35 CEST schrieb Constantine Kharlamov: > Thank you for testing! What is "UH4" btw? old GL3.3 benchmark Unigine Heaven 4.0 https://benchmark.unigine.com/heaven Marc > > On 26.04.2017 17:03, Marc Dietrich wrote: > > Am Dienstag, 25. April 2017, 13:59:44 CEST s

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Constantine Kharlamov
Thank you for testing! What is "UH4" btw? On 26.04.2017 17:03, Marc Dietrich wrote: > Am Dienstag, 25. April 2017, 13:59:44 CEST schrieb Constantine Kharlamov: >> Split out of "avoid redundant CB register updates" for easier review. >> >> Signed-off-by: Constantine Kharlamov >> Tested-by: Dieter

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Marc Dietrich
Am Dienstag, 25. April 2017, 13:59:44 CEST schrieb Constantine Kharlamov: > Split out of "avoid redundant CB register updates" for easier review. > > Signed-off-by: Constantine Kharlamov > Tested-by: Dieter Nützel > --- This one generates GPU crashes here (RS880) when running UH4: radeon :

[Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-25 Thread Constantine Kharlamov
Split out of "avoid redundant CB register updates" for easier review. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 76 +++- src/gallium/drivers/r600/r600_blit.c | 1 + src/gallium/drivers/r600/r