Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-24 Thread Brian Paul
On 05/23/2013 03:02 PM, Roland Scheidegger wrote: Am 23.05.2013 22:33, schrieb Zack Rusin: Gallium supported only a single viewport/scissor combination. This commit changes the interface to allow us to add support for multiple viewports/scissors. Signed-off-by: Zack Rusin --- diff --git a/src/

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-24 Thread Brian Paul
Just some minor formatting nits below... On 05/23/2013 02:33 PM, Zack Rusin wrote: Gallium supported only a single viewport/scissor combination. This commit changes the interface to allow us to add support for multiple viewports/scissors. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-23 Thread Marek Olšák
On Thu, May 23, 2013 at 11:59 PM, Zack Rusin wrote: >> 1) I prefer this interface instead: >> >> void (*set_scissor_states)( struct pipe_context *, >>unsigned start_slot, unsigned count, >>const struct pipe_scissor_state * ); >> >> vo

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-23 Thread Zack Rusin
> 1) I prefer this interface instead: > > void (*set_scissor_states)( struct pipe_context *, >unsigned start_slot, unsigned count, >const struct pipe_scissor_state * ); > > void (*set_viewport_states)( struct pipe_context *, >

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-23 Thread Marek Olšák
1) I prefer this interface instead: void (*set_scissor_states)( struct pipe_context *, unsigned start_slot, unsigned count, const struct pipe_scissor_state * ); void (*set_viewport_states)( struct pipe_context *,

Re: [Mesa-dev] [PATCH 1/4] gallium: Add support for multiple viewports

2013-05-23 Thread Roland Scheidegger
Am 23.05.2013 22:33, schrieb Zack Rusin: > Gallium supported only a single viewport/scissor combination. This > commit changes the interface to allow us to add support for multiple > viewports/scissors. > > Signed-off-by: Zack Rusin > --- > diff --git a/src/gallium/include/pipe/p_context.h > b/s