Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-07 Thread Mathias Fröhlich
Hi, On Tuesday, May 08, 2012 01:12:51 Marek Olšák wrote: > AFAIK the "Enabled" flags aren't very useful in determining the final > number of vertex elements, because if an array is not enabled, the > corresponding zero-stride "current" attrib is used instead. So the > quick check would depend sol

Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-07 Thread Marek Olšák
On Mon, May 7, 2012 at 6:34 PM, Brian Paul wrote: > On 05/07/2012 09:27 AM, Marek Olšák wrote: >> As far as the gallium side is concerned, I don't think the array >> object can fully encapsulate vertex buffers and vertex elements. Those >> two also depend on the vertex shader, because vertex buffe

Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-07 Thread Brian Paul
On 05/07/2012 09:27 AM, Marek Olšák wrote: On Mon, May 7, 2012 at 7:11 AM, Mathias Fröhlich wrote: Hi Marek, On Saturday, May 05, 2012 22:12:51 Marek Olšák wrote: could somebody please take a look at this series? It changes a couple of things in gl_context and the vbo module. The other two

Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-07 Thread Brian Paul
For the series, Reviewed-by: Brian Paul but I posted some comments for the other two patches. -Brian On 05/05/2012 02:12 PM, Marek Olšák wrote: Hi, could somebody please take a look at this series? It changes a couple of things in gl_context and the vbo module. The other two patches are: [

Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-07 Thread Marek Olšák
On Mon, May 7, 2012 at 7:11 AM, Mathias Fröhlich wrote: > > Hi Marek, > > On Saturday, May 05, 2012 22:12:51 Marek Olšák wrote: >> could somebody please take a look at this series? It changes a couple >> of things in gl_context and the vbo module. >> >> The other two patches are: >> [PATCH 2/3] me

Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-06 Thread Mathias Fröhlich
Hi Marek, On Saturday, May 05, 2012 22:12:51 Marek Olšák wrote: > could somebody please take a look at this series? It changes a couple > of things in gl_context and the vbo module. > > The other two patches are: > [PATCH 2/3] mesa: move gl_client_array*[] from vbo_draw_func into gl_context > [P

Re: [Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-05-05 Thread Marek Olšák
Hi, could somebody please take a look at this series? It changes a couple of things in gl_context and the vbo module. The other two patches are: [PATCH 2/3] mesa: move gl_client_array*[] from vbo_draw_func into gl_context [PATCH 3/3] mesa: add gl_context::NewDriverState and use it for vertex arra

[Mesa-dev] [PATCH 1/3] vbo: move vbo_draw_method into vbo_context.h

2012-04-24 Thread Marek Olšák
I'll need vbo_context in that function soon. --- src/mesa/vbo/vbo_context.h| 35 +++ src/mesa/vbo/vbo_exec.h | 36 src/mesa/vbo/vbo_exec_api.c |2 +- src/mesa/vbo/vbo_exec_array.c |2 +- src/mesa/vbo/vbo_s