Re: [Mesa-dev] [PATCH 1/3] i965/fs: Fix off-by-one in saturate propagation.

2014-04-04 Thread Matt Turner
On Fri, Apr 4, 2014 at 5:32 PM, Ian Romanick wrote: > Series is > > Reviewed-by: Ian Romanick > > Two questions... > > Are there piglit tests that exhibit the problems fixed by this series? Nope. It's the problem of figuring out how to write GLSL to generate just the right set of instructions, w

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Fix off-by-one in saturate propagation.

2014-04-04 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick Two questions... Are there piglit tests that exhibit the problems fixed by this series? Do any of these need to go back to stable? (I'm assuming not...) On 04/03/2014 05:30 PM, Matt Turner wrote: > ip needs to be initialized to start_ip - 1, since the first

[Mesa-dev] [PATCH 1/3] i965/fs: Fix off-by-one in saturate propagation.

2014-04-03 Thread Matt Turner
ip needs to be initialized to start_ip - 1, since the first thing in the main loop is ip++. Otherwise we would incorrectly propagate the saturate from the mov to the mad: mad a, b, c, d mov.sat x, a add y, z, a --- src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp | 2 +-