Series is
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
Two questions...
Are there piglit tests that exhibit the problems fixed by this series?
Do any of these need to go back to stable? (I'm assuming not...)
On 04/03/2014 05:30 PM, Matt Turner wrote:
> ip needs to be initialized to start_ip - 1, since the first thing in the
> main loop is ip++. Otherwise we would incorrectly propagate the saturate
> from the mov to the mad:
>
> mad a, b, c, d
> mov.sat x, a
> add y, z, a
> ---
> src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp
> index 189888e..eaecb45 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_saturate_propagation.cpp
> @@ -32,7 +32,7 @@ static bool
> opt_saturate_propagation_local(fs_visitor *v, bblock_t *block)
> {
> bool progress = false;
> - int ip = block->start_ip;
> + int ip = block->start_ip - 1;
>
> for (fs_inst *inst = (fs_inst *)block->start;
> inst != block->end->next;
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
