Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-20 Thread Pekka Paalanen
On Mon, 19 Dec 2011 13:24:20 -0800 Ian Romanick wrote: > On 12/19/2011 05:23 AM, Pekka Paalanen wrote: > > On Fri, 16 Dec 2011 10:46:11 -0800 > > Ian Romanick wrote: > > > >> On 12/14/2011 11:26 PM, Pekka Paalanen wrote: > >>> string_to_uint_map::put() already does a strdup() for the key > >>> a

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Pekka Paalanen
On Mon, 19 Dec 2011 11:02:31 -0800 Kenneth Graunke wrote: > On 12/19/2011 05:23 AM, Pekka Paalanen wrote: > > On Fri, 16 Dec 2011 10:46:11 -0800 > > Ian Romanick wrote: > > > >> On 12/14/2011 11:26 PM, Pekka Paalanen wrote: > >>> string_to_uint_map::put() already does a strdup() for the key > >

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Ian Romanick
On 12/19/2011 05:23 AM, Pekka Paalanen wrote: On Fri, 16 Dec 2011 10:46:11 -0800 Ian Romanick wrote: On 12/14/2011 11:26 PM, Pekka Paalanen wrote: string_to_uint_map::put() already does a strdup() for the key argument, so we leak the memory allocated by strdup() in link_uniforms.cpp. Remove

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Kenneth Graunke
On 12/19/2011 05:23 AM, Pekka Paalanen wrote: > On Fri, 16 Dec 2011 10:46:11 -0800 > Ian Romanick wrote: > >> On 12/14/2011 11:26 PM, Pekka Paalanen wrote: >>> string_to_uint_map::put() already does a strdup() for the key >>> argument, so we leak the memory allocated by strdup() in >>> link_unifo

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-19 Thread Pekka Paalanen
On Fri, 16 Dec 2011 10:46:11 -0800 Ian Romanick wrote: > On 12/14/2011 11:26 PM, Pekka Paalanen wrote: > > string_to_uint_map::put() already does a strdup() for the key > > argument, so we leak the memory allocated by strdup() in > > link_uniforms.cpp. > > > > Remove the extra strdup(), fixes a f

Re: [Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-16 Thread Ian Romanick
On 12/14/2011 11:26 PM, Pekka Paalanen wrote: string_to_uint_map::put() already does a strdup() for the key argument, so we leak the memory allocated by strdup() in link_uniforms.cpp. Remove the extra strdup(), fixes a few Valgrind detected leaks. Have you run piglit on this? I seem to recall

[Mesa-dev] [PATCH 1/2] linker: fix strdup memory leak

2011-12-14 Thread Pekka Paalanen
string_to_uint_map::put() already does a strdup() for the key argument, so we leak the memory allocated by strdup() in link_uniforms.cpp. Remove the extra strdup(), fixes a few Valgrind detected leaks. Signed-off-by: Pekka Paalanen --- src/glsl/link_uniforms.cpp |3 +-- 1 files changed, 1 i