Re: [Mesa-dev] [PATCH 09/12] i965/fs/skl+: Fix calculating gl_SampleID for 16x MSAA

2015-09-28 Thread Neil Roberts
Anuj Phogat writes: > As per docs we're supposed to get the per slot SampleID written to > 15:0 bits in R1.0. I used SSPI to compute the SampleID because I never > got anything useful in these bits on IVB. Things might have changed on > later platforms. So, I think it's worth trying to do what do

Re: [Mesa-dev] [PATCH 09/12] i965/fs/skl+: Fix calculating gl_SampleID for 16x MSAA

2015-09-24 Thread Anuj Phogat
On Tue, Sep 22, 2015 at 4:18 PM, Ben Widawsky wrote: > On Thu, Sep 17, 2015 at 05:00:11PM +0100, Neil Roberts wrote: > > In order to accomodate 16x MSAA, the starting sample pair index is now > > 3 bits rather than 2 on SKL+. > > Hooray for bad docs. "PS Thread Payload for Normal Dispatch": SSPI

Re: [Mesa-dev] [PATCH 09/12] i965/fs/skl+: Fix calculating gl_SampleID for 16x MSAA

2015-09-22 Thread Ben Widawsky
On Thu, Sep 17, 2015 at 05:00:11PM +0100, Neil Roberts wrote: > In order to accomodate 16x MSAA, the starting sample pair index is now > 3 bits rather than 2 on SKL+. Hooray for bad docs. "PS Thread Payload for Normal Dispatch": SSPI is 2 bits (R0.0.7:6) with 1 reserved for expansion. > --- > sr

[Mesa-dev] [PATCH 09/12] i965/fs/skl+: Fix calculating gl_SampleID for 16x MSAA

2015-09-17 Thread Neil Roberts
In order to accomodate 16x MSAA, the starting sample pair index is now 3 bits rather than 2 on SKL+. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp ind