Re: [Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

2018-06-13 Thread Nanley Chery
On Wed, Jun 13, 2018 at 09:25:02AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 12, 2018 at 12:21:56PM -0700, Nanley Chery wrote: > > Fix the case where only stencil writes are enabled on a depth stencil > > Isn't this an issue even when depth writes are enabled? Both would add the > same bo to c

Re: [Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

2018-06-12 Thread Pohjolainen, Topi
On Tue, Jun 12, 2018 at 12:21:56PM -0700, Nanley Chery wrote: > Fix the case where only stencil writes are enabled on a depth stencil Isn't this an issue even when depth writes are enabled? Both would add the same bo to cache? > texture. Found by inspection. > > --- > > I'm looking into writing

[Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

2018-06-12 Thread Nanley Chery
Fix the case where only stencil writes are enabled on a depth stencil texture. Found by inspection. --- I'm looking into writing a test for this. src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/