Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-10 Thread Eric Anholt
Marek Olšák writes: > Ping. Can I push this commit, Eric? > > Also, I don't think it's important what the > MAX_COMBINED_TEXTURE_IMAGE_UNITS limit is right now, because a program > object cannot have more than 16 samplers *combined* anyway > (Elements(gl_shader_program::SamplerUnits) == 16), so t

Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-10 Thread Marek Olšák
Ping. Can I push this commit, Eric? Also, I don't think it's important what the MAX_COMBINED_TEXTURE_IMAGE_UNITS limit is right now, because a program object cannot have more than 16 samplers *combined* anyway (Elements(gl_shader_program::SamplerUnits) == 16), so the old limit was wrong too. We h

Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-08 Thread Marek Olšák
On Thu, May 2, 2013 at 7:12 PM, Eric Anholt wrote: > Marek Olšák writes: > >> Shaders are unified on most hardware (= same limits in all stages). >> No idea what the assertion was good for. >> --- >> src/mesa/main/config.h |6 ++ >> src/mesa/main/context.c

Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-02 Thread Eric Anholt
Marek Olšák writes: > Shaders are unified on most hardware (= same limits in all stages). > No idea what the assertion was good for. > --- > src/mesa/main/config.h |6 ++ > src/mesa/main/context.c|6 ++ > src/mesa/state_tracker/st_extensions.c |

Re: [Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-02 Thread Brian Paul
On 05/01/2013 09:42 PM, Marek Olšák wrote: Shaders are unified on most hardware (= same limits in all stages). No idea what the assertion was good for. --- src/mesa/main/config.h |6 ++ src/mesa/main/context.c|6 ++ src/mesa/state_tracker/st_ext

[Mesa-dev] [PATCH 01/17] mesa: consolidate definitions of max texture image units

2013-05-01 Thread Marek Olšák
Shaders are unified on most hardware (= same limits in all stages). No idea what the assertion was good for. --- src/mesa/main/config.h |6 ++ src/mesa/main/context.c|6 ++ src/mesa/state_tracker/st_extensions.c |2 +- 3 files changed, 5 insertio