On Thu, 2016-07-07 at 20:12 -0700, Jason Ekstrand wrote:
>
> On Jul 7, 2016 7:47 PM, wrote:
> >
> >
> > On Jul 7, 2016 9:59 AM, "Kenneth Graunke"
> wrote:
> > >
> > > On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote:
> > > > This will be used to store the total number of components
On Jul 7, 2016 9:59 AM, "Kenneth Graunke" wrote:
>
> On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote:
> > This will be used to store the total number of components used at this
location
> > when packing via ARB_enhanced_layouts.
> > ---
> > src/compiler/glsl/glsl_to_nir.cpp | 1
On Jul 7, 2016 7:47 PM, wrote:
>
>
> On Jul 7, 2016 9:59 AM, "Kenneth Graunke" wrote:
> >
> > On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote:
> > > This will be used to store the total number of components used at
this location
> > > when packing via ARB_enhanced_layouts.
> > > ---
Patches 7, 8, 10-13 & 15-17 are simple enough,
Reviewed-by: Edward O'Callaghan
I would perhaps suggest squashing 16+17 together, up to you.
Kind Regards,
Edward.
On 07/08/2016 10:38 AM, Timothy Arceri wrote:
> On Thu, 2016-07-07 at 17:50 +1000, Edward O'Callaghan wrote:
>> Hi,
>>
>> There is a
On Thu, 2016-07-07 at 17:50 +1000, Edward O'Callaghan wrote:
> Hi,
>
> There is a typing issue in this patch in that, you are converting
> ‘gl_linked_shader*’ to ‘gl_shader*’ for the first argument to
> function
> ‘void set_num_packed_components(gl_shader*, ir_variable_mode,
> unsigned
> int)’ at
On Thursday, July 7, 2016 11:58:43 AM PDT Timothy Arceri wrote:
> This will be used to store the total number of components used at this
> location
> when packing via ARB_enhanced_layouts.
> ---
> src/compiler/glsl/glsl_to_nir.cpp | 1 +
> src/compiler/glsl/ir.h | 5 +++
> src/co
Hi,
There is a typing issue in this patch in that, you are converting
‘gl_linked_shader*’ to ‘gl_shader*’ for the first argument to function
‘void set_num_packed_components(gl_shader*, ir_variable_mode, unsigned
int)’ at the various call sites.
Cheers,
Edward.
On 07/07/2016 11:58 AM, Timothy Ar
This will be used to store the total number of components used at this location
when packing via ARB_enhanced_layouts.
---
src/compiler/glsl/glsl_to_nir.cpp | 1 +
src/compiler/glsl/ir.h | 5 +++
src/compiler/glsl/link_varyings.cpp | 74 -
src/c
