Re: [Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Mathias Fröhlich
Hi, On Wednesday, April 18, 2012 10:41:56 Brian Paul wrote: > Yes. I actually started some work on that a while back but never got > back to it. I don't think there'd be any harm in moving the field so > I'll go dig up that patch. > > My goal was to explore having an st_array_object subclass o

Re: [Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Brian Paul
On 04/18/2012 10:28 AM, Mathias Fröhlich wrote: Hi, On Wednesday, April 18, 2012 18:22:48 Marek Olšák wrote: BTW, the gl_array_attrib::NewState field is assigned to but never used anywhere. Want to remove it too? Hi Brian, I didn't remove it because I thought it would be useful in the futu

Re: [Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Mathias Fröhlich
Hi, On Wednesday, April 18, 2012 18:22:48 Marek Olšák wrote: > > BTW, the gl_array_attrib::NewState field is assigned to but never used > > anywhere. Want to remove it too? > > Hi Brian, > > I didn't remove it because I thought it would be useful in the future. > I wouldn't oppose somebody els

Re: [Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Mathias Fröhlich
Hi, That's actually a nice cleanup. There's a plenty potential for speeding up this area, but I did not find time to complete what I had/have in mind! For the series: Reviewed-by: Mathias Fröhlich Thanks! Mathias ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Marek Olšák
On Wed, Apr 18, 2012 at 5:02 PM, Brian Paul wrote: > On 04/18/2012 08:16 AM, Marek Olšák wrote: >> >> --- >>  src/mesa/state_tracker/st_context.h |   12 ++-- >>  1 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/src/mesa/state_tracker/st_context.h >> b/src/mesa/state_trac

Re: [Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Brian Paul
On 04/18/2012 08:16 AM, Marek Olšák wrote: --- src/mesa/state_tracker/st_context.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h index da03719..3d41ab5 100644 --- a/src/mesa/state_t

[Mesa-dev] [PATCH 01/10] st/mesa: use bitshifting to define state flags

2012-04-18 Thread Marek Olšák
--- src/mesa/state_tracker/st_context.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h index da03719..3d41ab5 100644 --- a/src/mesa/state_tracker/st_context.h +++ b/src/mesa/state_tracke