Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-12 Thread Ben Widawsky
On 17-01-12 14:44:33, Daniel Stone wrote: Hi Ben, On 3 January 2017 at 02:36, Ben Widawsky wrote: Same as v1 with the requested fixes and tags added. v1 is here: https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html I haven't yet updated kmscube to use Kristian's GET_PLAN

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-12 Thread Rob Clark
On Mon, Jan 2, 2017 at 9:36 PM, Ben Widawsky wrote: > Same as v1 with the requested fixes and tags added. v1 is here: > https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html > > I haven't yet updated kmscube to use Kristian's GET_PLANE2, but I will be > doing > it this week,

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-12 Thread Daniel Stone
Hi Ben, On 3 January 2017 at 02:36, Ben Widawsky wrote: > Same as v1 with the requested fixes and tags added. v1 is here: > https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html > > I haven't yet updated kmscube to use Kristian's GET_PLANE2, but I will be > doing > it this w

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-05 Thread Ben Widawsky
On 17-01-05 12:16:45, Chad Versace wrote: This patch has a regressing side-effect: it disables CCS for all single-sample miptrees created by glRenderbufferStorage(). After stepping through some Piglit tests, I believe the problem is that line 161 below always returns false for such miptrees becau

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-05 Thread Chad Versace
This patch has a regressing side-effect: it disables CCS for all single-sample miptrees created by glRenderbufferStorage(). After stepping through some Piglit tests, I believe the problem is that line 161 below always returns false for such miptrees because mt->is_scanout is true. I don't understan

[Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-02 Thread Ben Widawsky
Same as v1 with the requested fixes and tags added. v1 is here: https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html I haven't yet updated kmscube to use Kristian's GET_PLANE2, but I will be doing it this week, I hope. Now all patches but the last should be safe to merge with