Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

2017-03-22 Thread Emil Velikov
On 22 March 2017 at 11:02, Juha-Pekka Heikkila wrote: > On 20.03.2017 18:12, Emil Velikov wrote: >> >> Hi all, >> >> We have a strange mix of pragma once vs ifndef guards in-tree. >> >> Since the former is less common, and concluded as the 'wrong' way, >> I've went ahead and purged them. As a sinc

Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

2017-03-22 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan Thanks for getting rid of them Emil. On 03/21/2017 03:12 AM, Emil Velikov wrote: > Hi all, > > We have a strange mix of pragma once vs ifndef guards in-tree. > > Since the former is less common, and concluded as the 'wrong' way, > I've went ahead and purged them

Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

2017-03-22 Thread Juha-Pekka Heikkila
On 20.03.2017 18:12, Emil Velikov wrote: Hi all, We have a strange mix of pragma once vs ifndef guards in-tree. Since the former is less common, and concluded as the 'wrong' way, I've went ahead and purged them. As a since side effect I also fixed all the headers in the respective folders which

Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

2017-03-21 Thread Vedran Miletić
On 03/20/2017 05:12 PM, Emil Velikov wrote: > Hi all, > > We have a strange mix of pragma once vs ifndef guards in-tree. > > Since the former is less common, and concluded as the 'wrong' way, > I've went ahead and purged them. As a since side effect I also fixed > all the headers in the respectiv

Re: [Mesa-dev] [PATCH 00/18] Good bye pragma once

2017-03-20 Thread Lionel Landwerlin
Patches 1, 10, 11 & 12 look good to me : Acked-by: Lionel Landwerlin On 20/03/17 16:12, Emil Velikov wrote: Hi all, We have a strange mix of pragma once vs ifndef guards in-tree. Since the former is less common, and concluded as the 'wrong' way, I've went ahead and purged them. As a since si

[Mesa-dev] [PATCH 00/18] Good bye pragma once

2017-03-20 Thread Emil Velikov
Hi all, We have a strange mix of pragma once vs ifndef guards in-tree. Since the former is less common, and concluded as the 'wrong' way, I've went ahead and purged them. As a since side effect I also fixed all the headers in the respective folders which did not have either guard. With this in m