On 22 March 2017 at 11:02, Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> wrote: > On 20.03.2017 18:12, Emil Velikov wrote: >> >> Hi all, >> >> We have a strange mix of pragma once vs ifndef guards in-tree. >> >> Since the former is less common, and concluded as the 'wrong' way, >> I've went ahead and purged them. As a since side effect I also fixed >> all the headers in the respective folders which did not have either >> guard. >> >> With this in mind, we have one instance remaining in i965 (props to a >> python generator), and SWR driver is left untouched. >> >> The whole thing build fine on Linux (autotools, scons native and scons >> cross compile with mingw) and Windows (via Appveyor). >> >> I don't expect any real reviews here but an Ack or two will be >> appreciated. >> > > I read them through and all look good, they also compile all ok on my box. > Acked-by: Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> > Perfect ! Thank you Juha-Pekka/others for taking a look !
> I noticed "util/strndup.h" is included only into linker.cpp and > shader_query.cpp of which I didn't spot strndup being used anywhere in > shader_query.cpp. > There should be patch for that in your inbox ;-) -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
