Re: [Mesa-dev] [PATCH 0/6] Constants through builtins evaluation rewrite

2012-05-08 Thread Olivier Galibert
On Tue, May 08, 2012 at 01:09:25PM -0700, Kenneth Graunke wrote: > These look great! I've gone ahead and pushed them with a few tiny changes: > > 1. I updated a comment in patch 2, which still said the hash_table > mapped using variable names/strings. > 2. I changed the for (exec_node ...) loop

Re: [Mesa-dev] [PATCH 0/6] Constants through builtins evaluation rewrite

2012-05-08 Thread Kenneth Graunke
On 05/02/2012 02:11 PM, Olivier Galibert wrote: Hello, Here is the second version of that patch series. It's fundamentally the same thing with a number of changes: - respect the coding style a little better - index the hash table on the variable object pointer and not the name - handle funct

Re: [Mesa-dev] [PATCH 0/6] Constants through builtins evaluation rewrite

2012-05-08 Thread Olivier Galibert
On Wed, May 02, 2012 at 11:11:36PM +0200, Olivier Galibert wrote: > What's missing is a piglit run, which I currently have technical > problems with. Thanks to very pertinent advice by ajax and anholt I've been able to do a piglit run. With three additional bugfix patches I've sent independently

[Mesa-dev] [PATCH 0/6] Constants through builtins evaluation rewrite

2012-05-02 Thread Olivier Galibert
Hello, Here is the second version of that patch series. It's fundamentally the same thing with a number of changes: - respect the coding style a little better - index the hash table on the variable object pointer and not the name - handle function call in function call (tested with atan(a)) - h