Re: [Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe.

2012-06-11 Thread Jose Fonseca
- Original Message - > On Fri, Jun 08, 2012 at 09:01:42AM -0700, Jose Fonseca wrote: > > Oliver, > > > > There will be other system values in the future, so instead of > > passing every value as a different parameter, please define a > > structure in src/gallium/auxiliary/gallivm/lp_bld_

Re: [Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe.

2012-06-10 Thread Olivier Galibert
On Fri, Jun 08, 2012 at 09:01:42AM -0700, Jose Fonseca wrote: > Oliver, > > There will be other system values in the future, so instead of passing every > value as a different parameter, please define a structure in > src/gallium/auxiliary/gallivm/lp_bld_tgsi.h as > > struct lp_bld_tgsi_system_

Re: [Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe.

2012-06-08 Thread Jose Fonseca
Oliver, There will be other system values in the future, so instead of passing every value as a different parameter, please define a structure in src/gallium/auxiliary/gallivm/lp_bld_tgsi.h as struct lp_bld_tgsi_system_values { LLVMValueRef facing; LLVMValueRef instance_id; LLVMValueRef v

Re: [Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe. (v2)

2012-06-04 Thread Brian Paul
On 06/01/2012 03:28 PM, Olivier Galibert wrote: Hi, The following pair of patches add gl_VertexID support to llvmpipe. They also simplify the system value fetch methodology (hopefully generating better code in the end) and fixes some issues with gl_InstanceID. The "I don't understand how it

[Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe. (v2)

2012-06-01 Thread Olivier Galibert
Hi, The following pair of patches add gl_VertexID support to llvmpipe. They also simplify the system value fetch methodology (hopefully generating better code in the end) and fixes some issues with gl_InstanceID. The "I don't understand how it could ever work" kind of issues, converting from in

[Mesa-dev] [PATCH 0/2] Add vertex id to llvmpipe.

2012-06-01 Thread Olivier Galibert
Hi, The following pair of patches add gl_VertexID support to llvmpipe. They also simplify the system value fetch methodology (hopefully generating better code in the end) and fixes some issues with gl_InstanceID. The "I don't understand how it could ever work" kind of issues, converting from in