Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-23 Thread Erik Faye-Lund
On Jul 23, 2018 22:05, Dave Airlie wrote:On 20 July 2018 at 13:39, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first >> place is kinda pointless. >> >>

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-23 Thread Dave Airlie
On 20 July 2018 at 13:39, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first >> place is kinda pointless. >> >> Signed-off-by: Erik Faye-Lund >> --- >> >> This i

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-19 Thread Gurchetan Singh
Reviewed-by: Gurchetan Singh On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund wrote: > > The IOCTLs doesn't pass this along, so computing them in the first > place is kinda pointless. > > Signed-off-by: Erik Faye-Lund > --- > > This is just a cleanup I noticed based on some discussion with Gert. >

[Mesa-dev] [PATCH] virgl: remove unused stride-arguments

2018-07-18 Thread Erik Faye-Lund
The IOCTLs doesn't pass this along, so computing them in the first place is kinda pointless. Signed-off-by: Erik Faye-Lund --- This is just a cleanup I noticed based on some discussion with Gert. A question is, what code here expects this stride to be respected? The call-sites in virgl_*_transf