On 20 July 2018 at 13:39, Gurchetan Singh <gurchetansi...@chromium.org> wrote: > Reviewed-by: Gurchetan Singh <gurchetansi...@chromium.org> > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > <erik.faye-l...@collabora.com> wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first >> place is kinda pointless. >> >> Signed-off-by: Erik Faye-Lund <erik.faye-l...@collabora.com> >> --- >> >> This is just a cleanup I noticed based on some discussion with Gert. >> >> A question is, what code here expects this stride to be respected? The >> call-sites in virgl_*_transfer_map and virgl_*_transfer_unmap kinda >> looks like they do... They'll get a bit of a surprise here, no?
>> >> Anyway, this is already broken, so I think this should be OK. But >> perhaps this patch shows some code-paths that need some love? I reverted this as it didn't fixup vtest, and it introduced build time warnings. I agree this should get some more investigation but make sure vtest and drm backends don't regress. Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
