Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 16:15, Brian Paul wrote: > On 03/20/2018 05:41 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Stay consistent with the rest of the codebase, effectively fixing the >> autotools build. >> >> Bugzilla: >> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesk

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Brian Paul
On 03/20/2018 05:41 AM, Emil Velikov wrote: From: Emil Velikov Stay consistent with the rest of the codebase, effectively fixing the autotools build. Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D105621&d=DwIGaQ&c=uilaK90D4TOVoH58JNX

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 12:14, Bas Nieuwenhuizen wrote: > is compiler/nir/nir.h the preferred way? > > I checked src/amd and we are using "nir/nir.h" all the time. > Consistency within the subsystem is the key. Currently different subsystems have varying choices - language, formatting, coding style,..

Re: [Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Bas Nieuwenhuizen
is compiler/nir/nir.h the preferred way? I checked src/amd and we are using "nir/nir.h" all the time. On Tue, Mar 20, 2018 at 12:41 PM, Emil Velikov wrote: > From: Emil Velikov > > Stay consistent with the rest of the codebase, effectively fixing the > autotools build. > > Bugzilla: https://bug

[Mesa-dev] [PATCH] st/mesa: add compiler/nir/ prefix for nir includes

2018-03-20 Thread Emil Velikov
From: Emil Velikov Stay consistent with the rest of the codebase, effectively fixing the autotools build. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105621 Fixes: ffa4bbe4665 ("st/nir/radeonsi: move nir_lower_uniforms_to_ubo() to the state tracker") Cc: Timothy Arceri Signed-off-by: